fix: update body text and tests for PredirectInstructions

codingLogan · codingLogan · commit d9c831319d93 · 2025-12-23T14:29:46.000-07:00
diff --git a/src/const/language/es.json b/src/const/language/es.json
@@ -406,8 +406,6 @@
   "Unable to connect": "No se puede conectar",
   "Maintenance in progress": "Mantenimiento en curso",
   "Deposits verified. You're almost done setting things up. Continue to your institution.": "Depósitos verificados. Ya casi terminas de configurar todo. Continúa con tu institución.",
-  "After logging in, share at least one account and %1profile information%2.": "Después de iniciar sesión, comparta al menos una cuenta y %1información de perfil%2.",
-  "After logging in, share at least one account.": "Después de iniciar sesión, comparta al menos una cuenta.",
   "Connection not supported by %1": "Conexión no compatible con %1",
   "%1 currently limits how your data can be shared. We'll enable this connection once %1 opens access.": "%1 actualmente limita cómo se pueden compartir sus datos. Habilitaremos esta conexión una vez que %1 abra el acceso.",
   "UNAVAILABLE": "INDISPONIBLE",
@@ -422,6 +420,7 @@
   "Checking or savings account": "Cuenta corriente o de ahorros",
   "Profile information": "Información del perfil",
   "Account numbers": "Números de cuenta",
+  "To complete your connection, please %1share%2 the following after signing in:": "Para completar su conexión, por favor, %1comparta%2 lo siguiente después de iniciar sesión:",
   "connect/disclosure/button\u0004Continue": "Continuar",
   "connect/disclosure/policy/text\u0004By clicking Continue, you agree to the ": "Al hacer clic en Continuar, tu aceptas la ",
   "connect/disclosure/policy/link\u0004MX Privacy Policy.": "Política de privacidad de Money Experience.",
diff --git a/src/const/language/es.po b/src/const/language/es.po
@@ -2038,17 +2038,6 @@ msgstr ""
 "Depósitos verificados. Ya casi terminas de configurar todo. Continúa con tu "
 "institución."
 
-#: src/views/oauth/experiments/PredirectInstructions.tsx
-msgid ""
-"After logging in, share at least one account and %1profile information%2."
-msgstr ""
-"Después de iniciar sesión, comparta al menos una cuenta y %1información de "
-"perfil%2."
-
-#: src/views/oauth/experiments/PredirectInstructions.tsx
-msgid "After logging in, share at least one account."
-msgstr "Después de iniciar sesión, comparta al menos una cuenta."
-
 #: src/utilities/institutionStatus.ts
 msgid "Connection not supported by %1"
 msgstr "Conexión no compatible con %1"
@@ -2108,3 +2097,10 @@ msgstr "Información del perfil"
 #: src/views/oauth/experiments/PredirectInstructions.tsx
 msgid "Account numbers"
 msgstr "Números de cuenta"
+
+#: src/views/oauth/experiments/PredirectInstructions.tsx
+msgid ""
+"To complete your connection, please %1share%2 the following after signing in:"
+msgstr ""
+"Para completar su conexión, por favor, %1comparta%2 lo siguiente después de "
+"iniciar sesión:"
diff --git a/src/const/language/frCa.json b/src/const/language/frCa.json
@@ -407,8 +407,6 @@
   "Unable to connect": "Impossible de se connecter",
   "Maintenance in progress": "Entretien en cours",
   "Deposits verified. You're almost done setting things up. Continue to your institution.": "Dépôts vérifiés. Vous avez presque terminé la configuration. Rendez-vous dans votre établissement.",
-  "After logging in, share at least one account and %1profile information%2.": "Après vous être connecté, partagez au moins un compte et %1informations de profil%2.",
-  "After logging in, share at least one account.": "Après vous être connecté, partagez au moins un compte.",
   "Connection not supported by %1": "Connexion non prise en charge par %1",
   "%1 currently limits how your data can be shared. We'll enable this connection once %1 opens access.": "%1 limite actuellement la manière dont vos données peuvent être partagées. Nous activerons cette connexion une fois que %1 ouvrira l'accès.",
   "UNAVAILABLE": "INDISPONIBLE",
@@ -423,6 +421,7 @@
   "Checking or savings account": "Compte courant ou compte d'épargne",
   "Profile information": "Informations de profil",
   "Account numbers": "Numéros de compte",
+  "To complete your connection, please %1share%2 the following after signing in:": "Pour finaliser votre connexion, veuillez %1partager%2 les informations suivantes après vous être connecté :",
   "connect/disclosure/policy/text\u0004By clicking Continue, you agree to the ": "En cliquant sur Continuer, vous acceptez la ",
   "connect/disclosure/policy/link\u0004MX Privacy Policy.": "Politique de confidentialité de MX.",
   "connect/disclosure/policy/link\u0004MX Privacy Policy": "Politique de confidentialité de MX.",
diff --git a/src/const/language/frCa.po b/src/const/language/frCa.po
@@ -2116,17 +2116,6 @@ msgstr ""
 "Dépôts vérifiés. Vous avez presque terminé la configuration. Rendez-vous "
 "dans votre établissement."
 
-#: src/views/oauth/experiments/PredirectInstructions.tsx
-msgid ""
-"After logging in, share at least one account and %1profile information%2."
-msgstr ""
-"Après vous être connecté, partagez au moins un compte et %1informations de "
-"profil%2."
-
-#: src/views/oauth/experiments/PredirectInstructions.tsx
-msgid "After logging in, share at least one account."
-msgstr "Après vous être connecté, partagez au moins un compte."
-
 #: src/utilities/institutionStatus.ts
 msgid "Connection not supported by %1"
 msgstr "Connexion non prise en charge par %1"
@@ -2186,3 +2175,10 @@ msgstr "Informations de profil"
 #: src/views/oauth/experiments/PredirectInstructions.tsx
 msgid "Account numbers"
 msgstr "Numéros de compte"
+
+#: src/views/oauth/experiments/PredirectInstructions.tsx
+msgid ""
+"To complete your connection, please %1share%2 the following after signing in:"
+msgstr ""
+"Pour finaliser votre connexion, veuillez %1partager%2 les informations "
+"suivantes après vous être connecté :"
diff --git a/src/views/oauth/experiments/PredirectInstructions.tsx b/src/views/oauth/experiments/PredirectInstructions.tsx
@@ -1,11 +1,8 @@
 import React from 'react'
-import { useSelector } from 'react-redux'
 
 import 'src/views/oauth/experiments/PredirectInstructions.css'
 
-import { selectConnectConfig } from 'src/redux/reducers/configSlice'
-
-import { Icon, IconWeight, Text } from '@mxenabled/mxui'
+import { Text } from '@mxenabled/mxui'
 import { __ } from 'src/utilities/Intl'
 import { Divider, Paper } from '@mui/material'
 import { ExampleCheckbox } from 'src/components/ExampleCheckbox'
@@ -23,15 +20,13 @@ function PredirectInstructions(
     institution: InstitutionResponseType
   },
 ) {
-  const config = useSelector(selectConnectConfig)
-  const products = config?.data_request?.products || []
-  const showProfileSelection =
-    products.includes('account_verification') || products.includes('identity_verification')
-
+  // Filter out any invalid instruction values
   const configuredPredirectInstructions = Array.isArray(
     props.institution?.oauth_predirect_instructions,
   )
-    ? [...props.institution.oauth_predirect_instructions]
+    ? [...props.institution.oauth_predirect_instructions].filter((instruction) =>
+        Object.values(OAUTH_PREDIRECT_INSTRUCTION).includes(instruction),
+      )
     : []
 
   // Give Wells Fargo a default predirect instruction if none are configured, because we experimented on
@@ -46,6 +41,14 @@ function PredirectInstructions(
     )
   }
 
+  // If the instructions are still empty, provide a default of account and transactions
+  // for a better user experience.
+  if (configuredPredirectInstructions.length === 0) {
+    configuredPredirectInstructions.push(
+      OAUTH_PREDIRECT_INSTRUCTION.ACCOUNT_AND_TRANSACTIONS_INSTRUCTION,
+    )
+  }
+
   const institutionColor = getInstitutionBrandColor(props.institution, DEFAULT_HEADER_HEX_COLOR)
 
   const uiElementTypes = {
@@ -66,13 +69,11 @@ function PredirectInstructions(
   })
 
   /* Bold text is needed. The styles applied to this text prevent server-provided styles from ruining strong elements */
-  const instructionText = showProfileSelection
-    ? __(
-        'After logging in, share at least one account and %1profile information%2.',
-        "<strong style='font-weight: bold;'>",
-        '</strong>',
-      )
-    : __('After logging in, share at least one account.')
+  const instructionText = __(
+    'To complete your connection, please %1share%2 the following after signing in:',
+    "<strong style='font-weight: bold;'>",
+    '</strong>',
+  )
 
   return (
     <>
@@ -89,9 +90,6 @@ function PredirectInstructions(
           truncate={false}
           variant="body1"
         />
-        {showProfileSelection && (
-          <Icon color="secondary" name="info" size={20} weight={IconWeight.Dark} />
-        )}
       </div>
 
       <div className="institution-panel-wrapper">
diff --git a/src/views/oauth/experiments/__tests__/PredirectInstructions-test.tsx b/src/views/oauth/experiments/__tests__/PredirectInstructions-test.tsx
