fix: add Nova CLT guid to prevent initial data ready behaviors for Nova (#236)

Author: codingLogan

src/utilities/__tests__/pollers-test.js

@@ -217,7 +217,7 @@ describe('pollMember', () => {
   })
 
   describe('initial data ready functionality', () => {
-    it('should set initialDataReady flag when async_account_data_ready becomes true', (done) => {
+    it('should set initialDataReady flag when async_account_data_ready becomes true', async () => {
       const mockMember = createMockMember({
         connection_status: ReadableStatuses.CONNECTED,
         is_being_aggregated: false,
@@ -227,15 +227,63 @@ describe('pollMember', () => {
       mockApi.loadMemberByGuid.mockReturnValue(of(mockMember))
       mockApi.loadJob.mockReturnValue(of(mockJob))
 
-      const subscription = pollMember(memberGuid, mockApi, clientLocale)
-        .pipe(take(1))
-        .subscribe((result) => {
-          expect(result.initialDataReady).toBe(true)
-          done()
-        })
+      const resultPromise = new Promise((resolve, reject) => {
+        const subscription = pollMember(memberGuid, mockApi, clientLocale)
+          .pipe(take(1))
+          .subscribe({
+            next: (result) => {
+              subscription.unsubscribe()
+              resolve(result)
+            },
+            error: (error) => {
+              subscription.unsubscribe()
+              reject(error)
+            },
+          })
 
-      vi.advanceTimersByTime(3000)
-      subscription.unsubscribe()
+        // Advance timers to trigger the interval
+        vi.advanceTimersByTime(3000)
+      })
+
+      const result = await resultPromise
+      expect(result.initialDataReady).toBe(true)
+    })
+
+    it('should NOT set initialDataReady flag when async_account_data_ready becomes true and CLT guid is excluded', async () => {
+      const mockMember = createMockMember({
+        connection_status: ReadableStatuses.CONNECTED,
+        is_being_aggregated: false,
+      })
+      const mockJob = createMockJob(true)
+
+      mockApi.loadMemberByGuid.mockReturnValue(of(mockMember))
+      mockApi.loadJob.mockReturnValue(of(mockJob))
+
+      const resultPromise = new Promise((resolve, reject) => {
+        const subscription = pollMember(
+          memberGuid,
+          mockApi,
+          clientLocale,
+          'CLT-64ff7421-a8ef-4ac0-90f1-1636eda1a1fd',
+        )
+          .pipe(take(1))
+          .subscribe({
+            next: (result) => {
+              subscription.unsubscribe()
+              resolve(result)
+            },
+            error: (error) => {
+              subscription.unsubscribe()
+              reject(error)
+            },
+          })
+
+        // Advance timers to trigger the interval
+        vi.advanceTimersByTime(3000)
+      })
+
+      const result = await resultPromise
+      expect(result.initialDataReady).toBe(false)
     })
 
     it('should only set initialDataReady once, even on subsequent polls', (done) => {

src/utilities/pollers.js

@@ -26,7 +26,7 @@ export const DEFAULT_POLLING_STATE = {
   initialDataReady: false, // whether the initial data ready event has been sent
 }
 
-export function pollMember(memberGuid, api, clientLocale) {
+export function pollMember(memberGuid, api, clientLocale, clientGuid = null) {
   return interval(3000).pipe(
     switchMap(() =>
       // Poll the currentMember. Catch errors but don't handle it here
@@ -57,7 +57,14 @@ export function pollMember(memberGuid, api, clientLocale) {
           initialDataReady: acc.initialDataReady,
         }
 
-        if (!isError && !acc.initialDataReady && response?.job?.async_account_data_ready) {
+        // HARD CODED - GROSS...  Remove client exclusion when we know how to handle it properly
+        const excludedClients = ['CLT-64ff7421-a8ef-4ac0-90f1-1636eda1a1fd']
+        if (
+          !isError &&
+          !acc.initialDataReady &&
+          response?.job?.async_account_data_ready &&
+          !excludedClients.includes(clientGuid)
+        ) {
           pollingState.initialDataReady = true
         }
 

src/views/connecting/Connecting.js

@@ -48,6 +48,7 @@ import { POST_MESSAGES } from 'src/const/postMessages'
 import { AnalyticContext } from 'src/Connect'
 import { PostMessageContext } from 'src/ConnectWidget'
 import { Stack } from '@mui/material'
+import { getClientGuid } from 'src/redux/reducers/profilesSlice'
 
 export const Connecting = (props) => {
   const {
@@ -60,6 +61,7 @@ export const Connecting = (props) => {
   } = props
 
   const selectedInstitution = useSelector(getSelectedInstitution)
+  const clientGuid = useSelector(getClientGuid)
   const sendAnalyticsEvent = useAnalyticsEvent()
   const clientLocale = useMemo(() => {
     return document.querySelector('html')?.getAttribute('lang') || 'en'
@@ -127,6 +129,7 @@ export const Connecting = (props) => {
     }
 
     if (pollingState.initialDataReady) {
+      // Deprecated: send initial data ready post message Oct 17, 2025
       onPostMessage('connect/initialDataReady', {
         member_guid: pollingState.currentResponse?.member?.guid,
       })
@@ -280,7 +283,7 @@ export const Connecting = (props) => {
     })
       .pipe(
         concatMap((member) =>
-          pollMember(member.guid, api, clientLocale).pipe(
+          pollMember(member.guid, api, clientLocale, clientGuid).pipe(
             tap((pollingState) => handleMemberPoll(pollingState)),
             filter((pollingState) => pollingState.pollingIsDone),
             pluck('currentResponse'),