Skip to content

Investigate test overrides not effective when redirects are disabled #16410

Description

@janbrasna

Description

For some reason test_springfield_redirect_* or test_offsite_redirects_* fail if the settings are different than the current default, even when there is an override for this exactly:

@override_settings(ENABLE_FIREFOX_COM_REDIRECTS=True)

Steps to reproduce

ENABLE_FIREFOX_COM_REDIRECTS=False pytest bedrock/firefox

Expected result

pytest bedrock/firefox should pass given the setting override no matter what real setting.

Actual result

The suite fails if the actual setting is not True:

Image Image

Environment

ENABLE_FIREFOX_COM_REDIRECTS=False

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething's not working the way it shouldP3Third level priority - Nice to haveTech debtTech debt payoff

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions