Merge pull request eclipse-collections#1778 from motlin/reduceBy-overrides

Fix missing overrides of reduceBy().

Author: motlin

eclipse-collections-api/src/main/java/org/eclipse/collections/api/collection/MutableCollection.java

@@ -49,6 +49,7 @@
 import org.eclipse.collections.api.factory.primitive.ShortLists;
 import org.eclipse.collections.api.list.MutableList;
 import org.eclipse.collections.api.map.MutableMap;
+import org.eclipse.collections.api.map.MutableMapIterable;
 import org.eclipse.collections.api.map.primitive.MutableObjectDoubleMap;
 import org.eclipse.collections.api.map.primitive.MutableObjectLongMap;
 import org.eclipse.collections.api.multimap.MutableMultimap;
@@ -635,4 +636,12 @@ default <K, V> MutableMap<K, V> aggregateBy(
                 nonMutatingAggregator,
                 Maps.mutable.empty());
     }
+
+    @Override
+    default <K> MutableMapIterable<K, T> reduceBy(
+            Function<? super T, ? extends K> groupBy,
+            Function2<? super T, ? super T, ? extends T> reduceFunction)
+    {
+        return this.reduceBy(groupBy, reduceFunction, Maps.mutable.empty());
+    }
 }

eclipse-collections/src/main/java/org/eclipse/collections/impl/collection/mutable/AbstractMultiReaderMutableCollection.java

@@ -71,7 +71,6 @@
 import org.eclipse.collections.api.factory.primitive.ObjectLongMaps;
 import org.eclipse.collections.api.list.ImmutableList;
 import org.eclipse.collections.api.list.MutableList;
-import org.eclipse.collections.api.map.MapIterable;
 import org.eclipse.collections.api.map.MutableMap;
 import org.eclipse.collections.api.map.MutableMapIterable;
 import org.eclipse.collections.api.map.primitive.MutableObjectDoubleMap;
@@ -1440,7 +1439,7 @@ public <R extends Collection<Pair<T, Integer>>> R zipWithIndex(R target)
     }
 
     @Override
-    public <K> MapIterable<K, T> reduceBy(
+    public <K> MutableMapIterable<K, T> reduceBy(
             Function<? super T, ? extends K> groupBy,
             Function2<? super T, ? super T, ? extends T> reduceFunction)
     {

eclipse-collections/src/main/java/org/eclipse/collections/impl/collection/mutable/AbstractSynchronizedMutableCollection.java

@@ -40,6 +40,7 @@
 import org.eclipse.collections.api.collection.primitive.MutableShortCollection;
 import org.eclipse.collections.api.list.MutableList;
 import org.eclipse.collections.api.map.MutableMap;
+import org.eclipse.collections.api.map.MutableMapIterable;
 import org.eclipse.collections.api.map.primitive.MutableObjectDoubleMap;
 import org.eclipse.collections.api.map.primitive.MutableObjectLongMap;
 import org.eclipse.collections.api.multimap.MutableMultimap;
@@ -465,6 +466,17 @@ public <K, V> MutableMap<K, V> aggregateBy(
         }
     }
 
+    @Override
+    public <K> MutableMapIterable<K, T> reduceBy(
+            Function<? super T, ? extends K> groupBy,
+            Function2<? super T, ? super T, ? extends T> reduceFunction)
+    {
+        synchronized (this.lock)
+        {
+            return this.getDelegate().reduceBy(groupBy, reduceFunction);
+        }
+    }
+
     @Override
     public <V> MutableObjectLongMap<V> sumByInt(Function<? super T, ? extends V> groupBy, IntFunction<? super T> function)
     {