🐛 Bug Report: Android build fails with `react-native-contacts` on React Native 0.79 when `newArchEnabled=true`

[ajouve]

Summary:
After upgrading the app to React Native 0.79, the Android build fails when newArchEnabled=true, due to an incompatibility in react-native-contacts with the new architecture (TurboModules + Codegen). The ContactsManager class does not implement a required method from NativeContactsSpec.

---

💥 Error output:

ContactsManager is not abstract and does not override abstract method removeContactsFromGroup(String, ReadableArray, Promise) in NativeContactsSpec
public class ContactsManager extends NativeContactsSpec implements ActivityEventListener {
       ^

---

✅ Temporary Workaround:

Set the following in android/gradle.properties to disable the new architecture:

newArchEnabled=false

ℹ️ Environment:

• React Native: 0.79.2
• react-native-contacts: 8.0.5
• Platform: Android
• Architecture: New architecture enabled (Fabric / TurboModules)

[mare95]

I can confirm that this is happening in my project as well.

React Native: 0.79.2
react-native-contacts: 8.0.5
Platform: Android

Error output

ContactsManager is not abstract and does not override abstract method removeContactsFromGroup(String, ReadableArray, Promise) in NativeContactsSpec
public class ContactsManager extends NativeContactsSpec implements ActivityEventListener {

This has something to do with new bridgeless architecture

[linoleum00]

I can also confirm that this is happening in my project.

React Native: 0.79.2
react-native-contacts: 8.0.5
Platform: Android

Downgarded to 8.0.4 to build in android

[allisonadam81]

Same! 8.0.4 built, but Contacts was resolving to null for me.

Error requesting contacts permission: TypeError: Cannot read property 'requestPermission' of null

Fixed with this -
import Contacts from 'react-native-contacts/src/NativeContacts';

Taken from here -
https://stackoverflow.com/questions/79591867/why-is-contacts-module-null-in-react-native-cli-when-using-react-native-contacts

[djangoamidala]

I have personally created my own native module. I just need to get a list of contacts with their names, addresses, and images, so there’s not much left to do. I wrote the Android and iOS code in just 35 minutes. Damn npm, there are always so many issues after updates. Never any problems with all my native modules, even after years..

[allisonadam81]

FWIW - my solution is to leave new arch enabled to true, and then in a separate file do a platform dependent export for the correct contacts module.

import TurboContacts from 'react-native-contacts'
import NativeContacts from 'react-native-contacts/src/NativeContacts'

const Contacts = Platform.OS === 'android' ? NativeContacts : TurboContacts

export Contacts

Seems to work just fine for now.

[dannyhw]

getting this error too.

---

this patch gets it building for me

diff --git a/android/src/newarch/com/rt2zz/reactnativecontacts/ContactsManager.java b/android/src/newarch/com/rt2zz/reactnativecontacts/ContactsManager.java
index 78f5e0ea84e86307e0ca7e8926ef3792751514ee..834b49125efd08a12bc6dbbf2f6bc372938fcb77 100644
--- a/android/src/newarch/com/rt2zz/reactnativecontacts/ContactsManager.java
+++ b/android/src/newarch/com/rt2zz/reactnativecontacts/ContactsManager.java
@@ -10,6 +10,7 @@ import android.graphics.BitmapFactory;
 import com.facebook.react.bridge.ActivityEventListener;
 import com.facebook.react.bridge.Promise;
 import com.facebook.react.bridge.ReactApplicationContext;
+import com.facebook.react.bridge.ReadableArray;
 import com.facebook.react.bridge.ReadableMap;
 import com.rt2zz.reactnativecontacts.impl.ContactsManagerImpl;
 
@@ -222,6 +223,46 @@ public class ContactsManager extends NativeContactsSpec implements ActivityEvent
         // this method is only needed for iOS
     }
 
+    @Override
+    public void getGroups(Promise promise) {
+        
+    }
+
+    @Override
+    public void getGroup(String identifier, Promise promise) {
+
+    }
+
+    @Override
+    public void deleteGroup(String identifier, Promise promise) {
+
+    }
+
+    @Override
+    public void updateGroup(String identifier, ReadableMap groupData, Promise promise) {
+
+    }
+
+    @Override
+    public void addGroup(ReadableMap group, Promise promise) {
+
+    }
+
+    @Override
+    public void contactsInGroup(String identifier, Promise promise) {
+
+    }
+
+    @Override
+    public void addContactsToGroup(String groupIdentifier, ReadableArray contactIdentifiers, Promise promise) {
+
+    }
+
+    @Override
+    public void removeContactsFromGroup(String groupIdentifier, ReadableArray contactIdentifiers, Promise promise) {
+
+    }
+
 
     /*
     protected static void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions,

[vioku]

Temporary fix for folks who don't need group features

Tested on:

• "react-native": "0.78.2"
• "react-native-contacts": "^8.0.5"
• newArchEnabled=true in gradle.properties

Just tested this on Android (haven't tried on iOS yet tho 🙈).

🔧 Permissions added in ./android/app/src/main/AndroidManifest.xml:

<uses-permission android:name="android.permission.READ_CONTACTS" />
<uses-permission android:name="android.permission.WRITE_CONTACTS" />

🧼 Also commented out the group-related stuff in:

./node_modules/react-native-contacts/src/NativeContacts.ts

import type { TurboModule } from "react-native/Libraries/TurboModule/RCTExport";
import { TurboModuleRegistry } from "react-native";
import { Contact, Group, PermissionType } from "../type";

export interface Spec extends TurboModule {
  getAll: () => Promise<any>;
  getAllWithoutPhotos: () => Promise<Contact[]>;
  getContactById: (contactId: string) => Promise<Contact>;
  getCount: () => Promise<number>;
  getPhotoForId: (contactId: string) => Promise<string>;
  addContact: (contact: Object) => Promise<any>;
  openContactForm: (contact: Object) => Promise<Contact>;
  openExistingContact: (contact: Object) => Promise<Contact>;
  viewExistingContact: (contact: { recordID: string }) => Promise<Contact>;
  editExistingContact: (contact: Object) => Promise<Contact>;
  updateContact: (contact: Object) => Promise<void>;
  deleteContact: (contact: Object) => Promise<void>;
  getContactsMatchingString: (str: string) => Promise<Contact[]>;
  getContactsByPhoneNumber: (phoneNumber: string) => Promise<Contact[]>;
  getContactsByEmailAddress: (emailAddress: string) => Promise<Contact[]>;
  checkPermission: () => Promise<PermissionType>;
  requestPermission: () => Promise<PermissionType>;
  writePhotoToPath: (contactId: string, file: string) => Promise<boolean>;
  iosEnableNotesUsage: (enabled: boolean) => void;
  // getGroups(): Promise<Group[]>;
  // getGroup: (identifier: string) => Promise<Group | null>;
  // deleteGroup(identifier: string): Promise<boolean>;
  // updateGroup(identifier: string, groupData: Object): Promise<Group>;
  // addGroup(group: Object): Promise<Group>;
  // contactsInGroup(identifier: string): Promise<Contact[]>;
  // addContactsToGroup(
  //   groupIdentifier: string,
  //   contactIdentifiers: string[]
  // ): Promise<boolean>;
  // removeContactsFromGroup(
  //   groupIdentifier: string,
  //   contactIdentifiers: string[]
  // ): Promise<boolean>;
}

export default TurboModuleRegistry.get<Spec>("RCTContacts");

✅ Result

No more crashes for me (at least on Android 😅). If you're not using contact groups, this might be a quick workaround while waiting for the proper fix.

Hope this helps! 💖

[Bardiamist]

Created pull request #786

[shekhawatvivek]

can you please fix this i am getting my app crashed again and again

[shekhawatvivek]

Please update this bug facing a lot please

[Vivek1592002]

some one not even resolving the issue

[indresh149]

@morenoh149 Please fix this issue as android build fails and if we do not update it to latest then ios build fails

[Kaizodo]

if your android build is failing and you don't need contacts group then find the file ContactsManager.java in react-native-contacts (under node_modules or android studio error)
and add replace code with this

package com.rt2zz.reactnativecontacts;

import android.Manifest;
import android.app.Activity;
import android.content.Intent;
import android.content.res.AssetManager;
import android.graphics.Bitmap;
import android.graphics.BitmapFactory;

import com.facebook.react.bridge.ActivityEventListener;
import com.facebook.react.bridge.Promise;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.bridge.ReadableMap;
import com.rt2zz.reactnativecontacts.impl.ContactsManagerImpl;

import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.InputStream;

public class ContactsManager extends NativeContactsSpec implements ActivityEventListener {

    private final ContactsManagerImpl contactsManagerImpl;

    public ContactsManager(ReactApplicationContext reactContext) {
        super(reactContext);
        this.contactsManagerImpl = new ContactsManagerImpl(reactContext, true);
        reactContext.addActivityEventListener(this);
    }

    @Override
    public void removeContactsFromGroup(String groupId, ReadableArray contactIds, Promise promise) {
        // TODO: implement or handle as needed
    }

    @Override
    public void getGroups(Promise promise) {
        // TODO: implement or handle as needed
    }

    @Override
    public void getGroup(String groupId, Promise promise) {
        // TODO: implement or handle as needed
    }

    @Override
    public void deleteGroup(String identifier, Promise promise) {

    }

    @Override
    public void updateGroup(String identifier, ReadableMap groupData, Promise promise) {

    }

    @Override
    public void addGroup(ReadableMap group, Promise promise) {

    }

    @Override
    public void contactsInGroup(String identifier, Promise promise) {

    }

    @Override
    public void addContactsToGroup(String groupIdentifier, ReadableArray contactIdentifiers, Promise promise) {

    }

    /*
     * Returns all contactable records on phone
     * queries CommonDataKinds.Contactables to get phones and emails
     */
    @Override
    public void getAll(Promise promise) {
        contactsManagerImpl.getAll(promise);
    }

    /**
     * Introduced for iOS compatibility. Same as getAll
     *
     * @param promise promise
     */
    @Override
    public void getAllWithoutPhotos(Promise promise) {
        contactsManagerImpl.getAllWithoutPhotos(promise);
    }



    @Override
    public void getCount(final Promise promise) {
        contactsManagerImpl.getCount(promise);
    }

    /**
     * Retrieves contacts matching String.
     * Uses raw URI when <code>rawUri</code> is <code>true</code>, makes assets copy
     * otherwise.
     *
     * @param searchString String to match
     */
    @Override
    public void getContactsMatchingString(final String searchString, final Promise promise) {
        contactsManagerImpl.getContactsMatchingString(searchString, promise);
    }

    /**
     * Retrieves contacts matching a phone number.
     * Uses raw URI when <code>rawUri</code> is <code>true</code>, makes assets copy
     * otherwise.
     *
     * @param phoneNumber phone number to match
     */
    @Override
    public void getContactsByPhoneNumber(final String phoneNumber, final Promise promise) {
        contactsManagerImpl.getContactsByPhoneNumber(phoneNumber, promise);
    }

    /**
     * Retrieves contacts matching an email address.
     * Uses raw URI when <code>rawUri</code> is <code>true</code>, makes assets copy
     * otherwise.
     *
     * @param emailAddress email address to match
     */
    @Override
    public void getContactsByEmailAddress(final String emailAddress, final Promise promise) {
        contactsManagerImpl.getContactsByEmailAddress(emailAddress, promise);
    }

    /**
     * Retrieves <code>thumbnailPath</code> for contact, or <code>null</code> if not
     * available.
     *
     * @param contactId contact identifier, <code>recordID</code>
     */
    @Override
    public void getPhotoForId(final String contactId, final Promise promise) {
        contactsManagerImpl.getPhotoForId(contactId, promise);
    }

    /**
     * Retrieves <code>contact</code> for contact, or <code>null</code> if not
     * available.
     *
     * @param contactId contact identifier, <code>recordID</code>
     */
    @Override
    public void getContactById(final String contactId, final Promise promise) {
        contactsManagerImpl.getContactById(contactId, promise);
    }

    @Override
    public void writePhotoToPath(final String contactId, final String file, final Promise promise) {
        contactsManagerImpl.writePhotoToPath(contactId, file, promise);
    }

    private Bitmap getThumbnailBitmap(String thumbnailPath) {
        // Thumbnail from absolute path
        Bitmap photo = BitmapFactory.decodeFile(thumbnailPath);

        if (photo == null) {
            // Try to find the thumbnail from assets
            AssetManager assetManager = getReactApplicationContext().getAssets();
            InputStream inputStream = null;
            try {
                inputStream = assetManager.open(thumbnailPath);
                photo = BitmapFactory.decodeStream(inputStream);
                inputStream.close();
            } catch (IOException e) {
                e.printStackTrace();
            }
        }

        return photo;
    }

    /*
     * Start open contact form
     */
    @Override
    public void openContactForm(ReadableMap contact, Promise promise) {
        contactsManagerImpl.openContactForm(contact, promise);
    }

    /*
     * Open contact in native app
     */
    @Override
    public void openExistingContact(ReadableMap contact, Promise promise) {
        contactsManagerImpl.openExistingContact(contact, promise);
    }

    /*
     * View contact in native app
     */
    @Override
    public void viewExistingContact(ReadableMap contact, Promise promise) {
        contactsManagerImpl.viewExistingContact(contact, promise);
    }

    /*
     * Edit contact in native app
     */
    @Override
    public void editExistingContact(ReadableMap contact, Promise promise) {
        contactsManagerImpl.editExistingContact(contact, promise);
    }

    /*
     * Adds contact to phone's addressbook
     */
    @Override
    public void addContact(ReadableMap contact, Promise promise) {
        contactsManagerImpl.addContact(contact, promise);
    }

    public byte[] toByteArray(Bitmap bitmap) {
        ByteArrayOutputStream stream = new ByteArrayOutputStream();
        bitmap.compress(Bitmap.CompressFormat.JPEG, 80, stream);
        return stream.toByteArray();
    }

    /*
     * Update contact to phone's addressbook
     */
    @Override
    public void updateContact(ReadableMap contact, Promise promise) {
        contactsManagerImpl.updateContact(contact, promise);
    }

    /*
     * Update contact to phone's addressbook
     */
    @Override
    public void deleteContact(ReadableMap contact, Promise promise) {
        contactsManagerImpl.deleteContact(contact, promise);
    }

    /*
     * Check permission
     */
    @Override
    public void checkPermission(Promise promise) {
        contactsManagerImpl.checkPermission(promise);
    }

    /*
     * Request permission
     */
    @Override
    public void requestPermission(Promise promise) {
        contactsManagerImpl.requestPermission(promise);
    }

    /*
     * Enable note usage
     */
    @Override
    public void iosEnableNotesUsage(boolean enabled) {
        // this method is only needed for iOS
    }


    /*
    protected static void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions,
            @NonNull int[] grantResults) {
        if (requestPromise == null) {
            return;
        }

        if (requestCode != PERMISSION_REQUEST_CODE) {
            requestPromise.resolve(PERMISSION_DENIED);
            return;
        }

        Hashtable<String, Boolean> results = new Hashtable<>();
        for (int i = 0; i < permissions.length; i++) {
            results.put(permissions[i], grantResults[i] == PackageManager.PERMISSION_GRANTED);
        }

        if (results.containsKey(PERMISSION_READ_CONTACTS) && results.get(PERMISSION_READ_CONTACTS)) {
            requestPromise.resolve(PERMISSION_AUTHORIZED);
        } else {
            requestPromise.resolve(PERMISSION_DENIED);
        }

        requestPromise = null;
    }*/

    @Override
    public String getName() {
        return ContactsProvider.NAME;
    }

    /*
     * Required for ActivityEventListener
     */
    @Override
    public void onActivityResult(Activity activity, int requestCode, int resultCode, Intent data) {
        contactsManagerImpl.onActivityResult(activity, requestCode, resultCode, data);

    }

    /*
     * Required for ActivityEventListener
     */
    @Override
    public void onNewIntent(Intent intent) {
        contactsManagerImpl.onNewIntent(intent);
    }

}

[LarryKiniu]

@Kaizodo - works for me. Plus npx patch-package react-native-contacts to keep this fix.

[theol93]

here is patch based on this PR #786

react-native-contacts+8.0.5.patch