Skip to content

Commit bb78c65

Browse files
committed
fix variable usage
1 parent a5896fe commit bb78c65

1 file changed

Lines changed: 15 additions & 11 deletions

File tree

src/GitLabHealth-Model-Analysis/MergeRequestMergedByUserMetric.class.st

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,32 @@
11
Class {
22
#name : #MergeRequestMergedByUserMetric,
33
#superclass : #UserMergeRequestMetric,
4+
#instVars : [
5+
'allMergeRequestDuringPeriod'
6+
],
47
#category : #'GitLabHealth-Model-Analysis'
58
}
69

710
{ #category : #calculating }
811
MergeRequestMergedByUserMetric >> calculate [
912

1013
| groupedByDate userMergedMergeRequests dateOver |
11-
userMergeRequests ifNil: [ self load ].
14+
allMergeRequestDuringPeriod ifNil: [ self load ].
1215

1316
groupedByDate := self setupGroupedDate.
1417

1518
"filter to see the MR associated to one user"
16-
userMergedMergeRequests := userMergeRequests select: [
19+
userMergedMergeRequests := allMergeRequestDuringPeriod select: [
1720
:userMergeRequest |
18-
userMergeRequest merge_user isNotNil
19-
and: [ userMergeRequest merge_user id = user id ] ].
20-
21+
userMergeRequest merge_user isNotNil
22+
and: [
23+
userMergeRequest merge_user id = user id ] ].
24+
2125
"filter to reject MR that are not merge"
22-
userMergedMergeRequests := userMergedMergeRequests reject: [ :mr | mr merged_at isNil ].
23-
24-
userMergedMergeRequests do: [ :userMergeRequest |
25-
"here we look at the specific date of its merged"
26+
userMergedMergeRequests := userMergedMergeRequests reject: [ :mr |
27+
mr merged_at isNil ].
28+
29+
userMergedMergeRequests do: [ :userMergeRequest | "here we look at the specific date of its merged"
2630
dateOver := self transformDate: userMergeRequest merged_at to: over.
2731
groupedByDate
2832
at: dateOver printString
@@ -38,10 +42,10 @@ MergeRequestMergedByUserMetric >> description [
3842
^ 'number of merge request merged by this user'
3943
]
4044

41-
{ #category : #'as yet unclassified' }
45+
{ #category : #loading }
4246
MergeRequestMergedByUserMetric >> load [
4347

44-
userMergeRequests := self
48+
allMergeRequestDuringPeriod := self
4549
loadMergeRequestsSince: (period at: #since)
4650
until: (period at: #until)
4751
]

0 commit comments

Comments
 (0)