Skip to content

Commit b095727

Browse files
authored
Merge pull request #1118 from jecisc/duplication
Fix duplicated generation of specialized groups
2 parents c4bf42e + 2160b9a commit b095727

3 files changed

Lines changed: 3 additions & 20 deletions

File tree

src/Famix-MetamodelBuilder-Core/FmxMBRelationSide.class.st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ FmxMBRelationSide >> cardinality: anObject [
6161
FmxMBRelationSide >> container [
6262
"This method should not be called directly by the user. This is reserved to be used internaly in the builder."
6363

64-
self withNavigationOf: self relation.
64+
self relation withNavigation.
6565
container := true
6666
]
6767

src/Famix-MetamodelBuilder-Core/FmxMBRelationSideTrait.trait.st

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -72,39 +72,27 @@ FmxMBRelationSideTrait >> asRelationSideNamed: aPropertyName [
7272
FmxMBRelationSideTrait >> containsMany: aRelationSide [
7373

7474
| aRelation |
75-
7675
aRelation := self oneToMany: aRelationSide.
7776
aRelation right container.
78-
aRelation withNavigation.
79-
8077
^ aRelation
81-
8278
]
8379

8480
{ #category : 'relations - named containers' }
8581
FmxMBRelationSideTrait >> containsOne: aRelationSide [
8682

8783
| aRelation |
88-
8984
aRelation := self oneToOne: aRelationSide.
9085
aRelation right container.
91-
aRelation withNavigation.
92-
9386
^ aRelation
94-
9587
]
9688

9789
{ #category : 'relations - named containers' }
9890
FmxMBRelationSideTrait >> manyBelongTo: aRelationSide [
9991

10092
| aRelation |
101-
10293
aRelation := self manyToOne: aRelationSide.
10394
aRelation left container.
104-
aRelation withNavigation.
105-
10695
^ aRelation
107-
10896
]
10997

11098
{ #category : 'relations - named' }
@@ -154,13 +142,9 @@ FmxMBRelationSideTrait >> manyToOne: aRelationSide [
154142
FmxMBRelationSideTrait >> oneBelongsTo: aRelationSide [
155143

156144
| aRelation |
157-
158145
aRelation := self oneToOne: aRelationSide.
159146
aRelation left container.
160-
aRelation withNavigation.
161-
162147
^ aRelation
163-
164148
]
165149

166150
{ #category : 'relations - named' }

src/Famix-MetamodelBuilder-Tests/FmxMBRelationSideTest.class.st

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,11 @@ FmxMBRelationSideTest >> testProperties [
125125
side := FmxMBRelationSide new.
126126

127127
self deny: side isContainer.
128-
side container.
128+
side container: true.
129129
self assert: side isContainer.
130130
side container: false.
131131
self deny: side isContainer.
132-
side container.
133-
self assert: side isContainer.
132+
side container: true.
134133
side noContainer.
135134
self deny: side isContainer.
136135

0 commit comments

Comments
 (0)