Skip to content

Commit 404374b

Browse files
committed
fix: address PR review comments
- Change CI workflow cache from npm to pnpm - Use logger.error consistently instead of console.error - Regenerate pnpm-lock.yaml to fix spurious catalog deletions
1 parent ce94b64 commit 404374b

File tree

3 files changed

+63
-10
lines changed

3 files changed

+63
-10
lines changed

.github/workflows/conformance.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- uses: actions/setup-node@v4
1919
with:
2020
node-version: 24
21-
cache: npm
21+
cache: pnpm
2222
- uses: pnpm/action-setup@v4
2323
with:
2424
version: 10.24.0

pnpm-lock.yaml

Lines changed: 53 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/conformance/everything-client.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -385,25 +385,25 @@ async function main(): Promise<void> {
385385
const serverUrl = process.argv[2];
386386

387387
if (!scenarioName || !serverUrl) {
388-
console.error(
388+
logger.error(
389389
'Usage: MCP_CONFORMANCE_SCENARIO=<scenario> everything-client <server-url>'
390390
);
391-
console.error(
391+
logger.error(
392392
'\nThe MCP_CONFORMANCE_SCENARIO env var is set automatically by the conformance runner.'
393393
);
394-
console.error('\nAvailable scenarios:');
394+
logger.error('\nAvailable scenarios:');
395395
for (const name of Object.keys(scenarioHandlers).sort()) {
396-
console.error(` - ${name}`);
396+
logger.error(` - ${name}`);
397397
}
398398
process.exit(1);
399399
}
400400

401401
const handler = scenarioHandlers[scenarioName];
402402
if (!handler) {
403-
console.error(`Unknown scenario: ${scenarioName}`);
404-
console.error('\nAvailable scenarios:');
403+
logger.error(`Unknown scenario: ${scenarioName}`);
404+
logger.error('\nAvailable scenarios:');
405405
for (const name of Object.keys(scenarioHandlers).sort()) {
406-
console.error(` - ${name}`);
406+
logger.error(` - ${name}`);
407407
}
408408
process.exit(1);
409409
}
@@ -412,12 +412,12 @@ async function main(): Promise<void> {
412412
await handler(serverUrl);
413413
process.exit(0);
414414
} catch (error) {
415-
console.error('Error:', error);
415+
logger.error('Error:', error);
416416
process.exit(1);
417417
}
418418
}
419419

420420
main().catch((error) => {
421-
console.error('Unhandled error:', error);
421+
logger.error('Unhandled error:', error);
422422
process.exit(1);
423423
});

0 commit comments

Comments
 (0)