Skip to content

mlpstorage arguments have confusing names that conflict with IEC standards #207

@jeking3

Description

@jeking3

According to the code, CLIENT_HOST_MEMORY_IN_GB is actually in GiB:
https://github.com/search?q=repo%3Amlcommons%2Fstorage%20CLIENT_HOST_MEMORY_IN_GB&type=code

    elif args.client_host_memory_in_gb and args.num_client_hosts:
        # If host memory per client and num clients is provided, we use these values instead of the calculated memory
        per_host_memory_in_bytes = args.client_host_memory_in_gb * 1024 * 1024 * 1024

The command takes --client-host-memory-in-gb as an argument, not --client-host-memory-in-gib. These distinctions are important. The README.md and command help should be updated to make it clear this is in GiB units. Refer to https://physics.nist.gov/cuu/Units/binary.html for more details.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions