Helpers: createDefaultClient() remembers last instance

Author: milo

src/Github/Helpers.php

@@ -22,6 +22,10 @@ class Helpers
 	];
 
 
+	/** @var Http\IClient */
+	private static $client;
+
+
 	/**
 	 * @param  mixed
 	 * @return string
@@ -80,13 +84,18 @@ public static function jsonDecode($json)
 
 
 	/**
+	 * @param  bool
 	 * @return Http\IClient
 	 */
-	public static function createDefaultClient()
+	public static function createDefaultClient($newInstance = FALSE)
 	{
-		return extension_loaded('curl')
-			? new Http\CurlClient
-			: new Http\StreamClient;
+		if (self::$client === NULL || $newInstance) {
+			self::$client = extension_loaded('curl')
+				? new Http\CurlClient
+				: new Http\StreamClient;
+		}
+
+		return self::$client;
 	}
 
 }

tests/Github/Helpers.phpt

@@ -0,0 +1,23 @@
+<?php
+
+/**
+ * @author  Miloslav Hůla
+ */
+
+require __DIR__ . '/../bootstrap.php';
+
+
+$client1 = Milo\Github\Helpers::createDefaultClient();
+Assert::type('Milo\Github\Http\IClient', $client1);
+
+$client2 = Milo\Github\Helpers::createDefaultClient();
+Assert::type('Milo\Github\Http\IClient', $client2);
+
+Assert::same($client1, $client2);
+
+
+$client3 = Milo\Github\Helpers::createDefaultClient(TRUE);
+Assert::type('Milo\Github\Http\IClient', $client3);
+
+Assert::notSame($client1, $client3);
+Assert::notSame($client2, $client3);