Skip to content

Commit 97211b8

Browse files
authored
Address PR feedback from the massive build change (#3991)
* address code review feedback * Change files
1 parent 9729c04 commit 97211b8

File tree

8 files changed

+30
-4
lines changed

8 files changed

+30
-4
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "address code review feedback",
4+
"packageName": "@fluentui-react-native/menu",
5+
"email": "jasonmo@microsoft.com",
6+
"dependentChangeType": "none"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "address code review feedback",
4+
"packageName": "@fluentui-react-native/overflow",
5+
"email": "jasonmo@microsoft.com",
6+
"dependentChangeType": "none"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "address code review feedback",
4+
"packageName": "@fluentui-react-native/tablist",
5+
"email": "jasonmo@microsoft.com",
6+
"dependentChangeType": "none"
7+
}

packages/components/Menu/src/MenuTrigger/useMergeRefs.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ export function useMergedRefs<T>(...refs: (React.Ref<T> | undefined)[]): RefObje
3434
}
3535
}
3636
},
37-
3837
[...refs],
3938
) as unknown as RefObjectFunction<T>;
4039

packages/components/TabList/src/TabList/useTabList.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@ export const useTabList = (props: TabListProps): TabListInfo => {
160160
setFocusedTabRef(ref);
161161
}
162162
}
163-
// Disable exhaustive-deps warning because this hook should only run once 'isSelectedTabDisabled' dependency changes.
164163
}, [isSelectedTabDisabled]);
165164

166165
// win32 only prop used to implemement CTRL + TAB shortcut native to windows tab components

packages/components/TabList/src/TabListAnimatedIndicator/useAnimatedIndicatorStyles.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ export function useAnimatedIndicatorStyles(props: AnimatedIndicatorProps): Anima
1616
const indicatorScale = React.useRef(new Animated.Value(1)).current;
1717

1818
// Save the initial selected layout, this shouldn't update after the first render.
19-
2019
const startingKey = React.useMemo(() => selectedKey, []);
2120

2221
React.useEffect(() => {

packages/experimental/Overflow/src/Overflow/useOverflow.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ export function useOverflow(props: OverflowProps): OverflowInfo {
7171
overflowManager.removeItem(id);
7272
},
7373
// overflowManager is not needed as a dependency, due to being attached to a ref
74-
7574
[overflowItemUpdateCallbacks],
7675
);
7776

scripts/src/utils/env.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
1+
/**
2+
* Lage doesn't support cleanly passing parameters to sub scripts, so this allows our scripts that
3+
* support a "fix" mode to be toggled via an environment variable. This allows things like lint --fix or
4+
* lint-package --fix to be run from the root level without having to have duplicate scripts entries for
5+
* each package.
6+
*/
7+
8+
// env variable to use
19
export const FIX_ENV_VAR = 'FURN_FIX_MODE';
210

11+
// standard helper function to check for fix mode
312
export function isFixMode(fromParam?: boolean): boolean {
413
return fromParam || Boolean(process.env[FIX_ENV_VAR]);
514
}

0 commit comments

Comments
 (0)