Dicom Cast Validation Bug (#3342)

* fix validation bug

* Update observation pareser to create dicom code items individually

* add a test case

Author: abdullah248

converter/dicom-cast/src/Microsoft.Health.DicomCast.Core.UnitTests/Features/Worker/FhirTransaction/Observation/ObservationParserTests.cs

@@ -1,4 +1,4 @@
-// -------------------------------------------------------------------------------------------------
+// -------------------------------------------------------------------------------------------------
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License (MIT). See LICENSE in the repo root for license information.
 // -------------------------------------------------------------------------------------------------
@@ -254,4 +254,25 @@ public void RadiationEventWithoutIrradiationEventUid()
             new Identifier());
         Assert.Empty(observations);
     }
+
+    [Fact]
+    public void RadiationEventWithInvalidDataNotInCodeCodeNoErrorThrown()
+    {
+        var report = new DicomStructuredReport(
+            ObservationConstants.IrradiationEventXRayData,
+            new DicomContentItem(
+                ObservationConstants.IrradiationEventUid,
+                DicomRelationship.Contains,
+                new DicomUID("1.3.12.2.1234.5.4.5.123123.3000000111", "foobar", DicomUidType.Unknown)
+            ));
+        report.Dataset.NotValidated();
+        report.Dataset.Add(DicomTag.PatientBirthDateInAlternativeCalendar, "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz");
+
+        var observations = ObservationParser.Parse(
+            report.Dataset,
+            new ResourceReference(),
+            new ResourceReference(),
+            new Identifier());
+        Assert.Single(observations);
+    }
 }

converter/dicom-cast/src/Microsoft.Health.DicomCast.Core/Features/Worker/FhirTransaction/Observation/ObservationParser.cs

@@ -32,13 +32,24 @@ private static IEnumerable<Observation> ParseDicomDataset(DicomDataset dataset,
     {
         if (dataset.TryGetSequence(DicomTag.ConceptNameCodeSequence, out DicomSequence codes) && codes.Items.Count > 0)
         {
-            var code = new DicomCodeItem(codes);
+            Observation observation = null;
+            try
+            {
+                var code = createDicomCode(codes);
+
+                if (ObservationConstants.IrradiationEvents.Contains(code) && TryCreateIrradiationEvent(dataset, patientReference, identifier, out Observation irradiationEvent))
+                    observation = irradiationEvent;
 
-            if (ObservationConstants.IrradiationEvents.Contains(code) && TryCreateIrradiationEvent(dataset, patientReference, identifier, out Observation irradiationEvent))
-                yield return irradiationEvent;
+                if (ObservationConstants.DoseSummaryReportCodes.Contains(code))
+                    observation = CreateDoseSummary(dataset, imagingStudyReference, patientReference, identifier);
+            }
+            catch (DicomValidationException)
+            {
+                observation = null; //we can safely ignore any validation errors since we are only looking for irradiation and dose summary reports specifically. If the code fails to validate then it will not match either report.
+            }
 
-            if (ObservationConstants.DoseSummaryReportCodes.Contains(code))
-                yield return CreateDoseSummary(dataset, imagingStudyReference, patientReference, identifier);
+            if (observation != null)
+                yield return observation;
         }
 
         // Recursively iterate through every child in the document checking for nested observations.
@@ -53,6 +64,16 @@ private static IEnumerable<Observation> ParseDicomDataset(DicomDataset dataset,
         }
     }
 
+    // We do not use the built in fo dicom method to create dicom codes as that validates the entire dataset by default and we do not want to do that
+    private static DicomCodeItem createDicomCode(DicomSequence sequence)
+    {
+        string codeValue = sequence.Items[0].GetValueOrDefault(DicomTag.CodeValue, 0, string.Empty);
+        string scheme = sequence.Items[0].GetValueOrDefault(DicomTag.CodingSchemeDesignator, 0, string.Empty);
+        string meaning = sequence.Items[0].GetValueOrDefault(DicomTag.CodeMeaning, 0, string.Empty);
+
+        return new DicomCodeItem(codeValue, scheme, meaning);
+    }
+
     private static Observation CreateDoseSummary(
         DicomDataset dataset,
         ResourceReference imagingStudyReference,