Add weak_ptr to NetworkInformation in SetupNetDetect

thomasameisel · web-flow · commit 9ebeca59e76f · 2026-01-05T15:44:25.000-08:00
diff --git a/lib/pal/posix/NetworkInformationImpl.mm b/lib/pal/posix/NetworkInformationImpl.mm
@@ -105,6 +105,8 @@ virtual NetworkCost GetNetworkCost()
     {
         if (@available(macOS 10.14, iOS 12.0, *))
         {
+            auto weak_this = std::weak_ptr<NetworkInformation>(shared_from_this());
+
             m_monitor = nw_path_monitor_create();
             nw_path_monitor_set_queue(m_monitor, dispatch_get_global_queue(QOS_CLASS_BACKGROUND, 0));
             nw_path_monitor_set_update_handler(m_monitor, ^(nw_path_t path)

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,8 @@ virtual NetworkCost GetNetworkCost()`
`105`	`105`	`{`
`106`	`106`	`if (@available(macOS 10.14, iOS 12.0, *))`
`107`	`107`	`{`
	`108`	`+ auto weak_this = std::weak_ptr<NetworkInformation>(shared_from_this());`
	`109`	`+`
`108`	`110`	`m_monitor = nw_path_monitor_create();`
`109`	`111`	`nw_path_monitor_set_queue(m_monitor, dispatch_get_global_queue(QOS_CLASS_BACKGROUND, 0));`
`110`	`112`	`nw_path_monitor_set_update_handler(m_monitor, ^(nw_path_t path)`