Skip to content

Commit e12b0a1

Browse files
sss04mhamilton723
andauthored
fix: Adding trailing / to URLs set (#2364)
* [fix] Adding trailing / to URLs set * Update tests --------- Co-authored-by: Mark Hamilton <mhamilton723@gmail.com>
1 parent 53b76a8 commit e12b0a1

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIDefaults.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ object OpenAIDefaults {
4545
}
4646

4747
def setURL(v: String): Unit = {
48-
GlobalParams.setGlobalParam(URLKey, v)
48+
val url = if (v.endsWith("/")) v else v + "/"
49+
GlobalParams.setGlobalParam(URLKey, url)
4950
}
5051

5152
def getURL: Option[String] = {

cognitive/src/test/python/synapsemltest/services/openai/test_OpenAIDefaults.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ def test_setters_and_getters(self):
2121
defaults.set_deployment_name("Bing Bong")
2222
defaults.set_subscription_key("SubKey")
2323
defaults.set_temperature(0.05)
24-
defaults.set_URL("Test URL")
24+
defaults.set_URL("Test URL/")
2525

2626
self.assertEqual(defaults.get_deployment_name(), "Bing Bong")
2727
self.assertEqual(defaults.get_subscription_key(), "SubKey")
2828
self.assertEqual(defaults.get_temperature(), 0.05)
29-
self.assertEqual(defaults.get_URL(), "Test URL")
29+
self.assertEqual(defaults.get_URL(), "Test URL/")
3030

3131
def test_resetters(self):
3232
defaults = OpenAIDefaults()
@@ -39,7 +39,7 @@ def test_resetters(self):
3939
self.assertEqual(defaults.get_deployment_name(), "Bing Bong")
4040
self.assertEqual(defaults.get_subscription_key(), "SubKey")
4141
self.assertEqual(defaults.get_temperature(), 0.05)
42-
self.assertEqual(defaults.get_URL(), "Test URL")
42+
self.assertEqual(defaults.get_URL(), "Test URL/")
4343

4444
defaults.reset_deployment_name()
4545
defaults.reset_subscription_key()

0 commit comments

Comments
 (0)