fix: improve subcontracting management setup procedures

- Ensure proper handling of subcontracting worksheet template creation.
- Exit early if template creation fails to prevent incorrect setup.
- Update procedures to return boolean values for better error handling.

Author: stevengrossGOB

src/Apps/W1/Subcontracting/App/src/Install/SubcontractingCompInit.Codeunit.al

@@ -23,32 +23,37 @@ codeunit 99001503 "Subcontracting Comp. Init."
             ManufacturingSetup.Insert(true);
         end;
 
-        CreateSubcontractingReqWkshTemplateAndNameAndUpdateSetup(ManufacturingSetup);
+        if not CreateSubcontractingReqWkshTemplateAndNameAndUpdateSetup(ManufacturingSetup) then
+            exit;
+
         ManufacturingSetup."Direct Transfer" := true;
         ManufacturingSetup."Create Prod. Order Info Line" := true;
         Evaluate(ManufacturingSetup."Subc. Inb. Whse. Handling Time", GetDefaultInboundWhseHandlingTime());
         ManufacturingSetup.Modify(true);
     end;
 
-    procedure CreateSubcontractingReqWkshTemplateAndNameAndUpdateSetup(var ManufacturingSetup: Record "Manufacturing Setup")
+    procedure CreateSubcontractingReqWkshTemplateAndNameAndUpdateSetup(var ManufacturingSetup: Record "Manufacturing Setup"): Boolean
     var
         ReqWkshTemplate: Record "Req. Wksh. Template";
         RequisitionWkshName: Record "Requisition Wksh. Name";
     begin
-        CreateReqWkshTemplate(ReqWkshTemplate, false);
+        if not CreateReqWkshTemplate(ReqWkshTemplate, false) then
+            exit(false);
+
         CreateRequisitionWkshName(RequisitionWkshName, ReqWkshTemplate.Name);
         ManufacturingSetup."Subcontracting Template Name" := ReqWkshTemplate.Name;
         ManufacturingSetup."Subcontracting Batch Name" := RequisitionWkshName.Name;
+        exit(true);
     end;
 
-    procedure CreateReqWkshTemplate(var ReqWkshTemplate: Record "Req. Wksh. Template"; Recurring: Boolean)
+    procedure CreateReqWkshTemplate(var ReqWkshTemplate: Record "Req. Wksh. Template"; Recurring: Boolean): Boolean
     var
         ReqWkshTempDescLbl: Label 'Subcontracting', MaxLength = 80;
         ReqWkshTempNameLbl: Label 'SUBCONTR', MaxLength = 10;
     begin
         ReqWkshTemplate.SetRange(Type, ReqWkshTemplate.Type::Subcontracting);
         if ReqWkshTemplate.FindFirst() then
-            exit;
+            exit(false);
 
         ReqWkshTemplate.Init();
         ReqWkshTemplate.Validate(Name, ReqWkshTempNameLbl);
@@ -57,6 +62,7 @@ codeunit 99001503 "Subcontracting Comp. Init."
         ReqWkshTemplate.Validate(Type, ReqWkshTemplate.Type::Subcontracting);
         ReqWkshTemplate.Validate("Page ID", Page::"Subc. Subcontracting Worksheet");
         ReqWkshTemplate.Insert(true);
+        exit(true);
     end;
 
     procedure CreateRequisitionWkshName(var RequisitionWkshName: Record "Requisition Wksh. Name"; WorksheetTemplateName: Text)