Fix for duplicated icons in test result visualizer. (#1691)

Fixes #1678

Author: spetersenms

Actions/AnalyzeTests/TestResultAnalyzer.ps1

@@ -23,27 +23,32 @@ function BuildTestMarkdownTable {
         [hashtable] $resultIcons
     )
 
+    $mdTableRows = [System.Collections.ArrayList]@()
     $mdTableSB = [System.Text.StringBuilder]::new()
 
     foreach($row in $Rows) {
-        Write-Host $row
+        $row -join ',' | Out-Host
+        $formattedRow = @()
         for($i=0; $i -lt $row.Length; $i++) {
             #If resultIcons has a key for this column, we want to display an emoji for values > 0 and an empty cell for 0
             if ($resultIcons.ContainsKey($i)) {
                 if ($row[$i] -gt 0) {
-                    $row[$i] = "$($row[$i])$($resultIcons[$i])"
+                    $formattedRow += "$($row[$i])$($resultIcons[$i])"
                 }
                 else {
-                    $row[$i] = $null
+                    $formattedRow += ""
                 }
+            } else {
+                $formattedRow += "$($row[$i])"
             }
         }
-        Write-Host $row
+        $mdTableRows.Add($formattedRow) | Out-Null
+        "|$($formattedRow -join '|')|" | Out-Host
     }
 
     $mdTable = ''
     try {
-        $mdTable = Build-MarkdownTable -Headers $Headers -Rows $Rows
+        $mdTable = Build-MarkdownTable -Headers $Headers -Rows $mdTableRows
     } catch {
         $mdTable = "<i>Failed to generate result table</i>"
     }
@@ -198,8 +203,8 @@ function GetTestResultSummaryMD {
                     }
                     $failuresSB = BuildHTMLFailureSummary -rootFailureNode $rootFailureNode
                 }
-                $summarySb = BuildTestMarkdownTable -Headers $mdTableHeaders -Rows $mdTableRows -resultIcons $mdTableEmojis
             }
+            $summarySb = BuildTestMarkdownTable -Headers $mdTableHeaders -Rows $mdTableRows -resultIcons $mdTableEmojis
         }
         if ($totalFailed -gt 0) {
             $failuresSummaryMD = "<i>$totalFailed failing tests, download test results to see details</i>"

RELEASENOTES.md

@@ -1,5 +1,6 @@
 ### Issues
 
+- Issue 1678 Test summary is showing too many status icons
 - Issue 1640 AL1040 error due to app folder within the artifacts cache being incorrectly recognized as an app folder
 - Issue 1630 Error when downloading a release, when the destination folder already exists.
 - Issue 1540 and 1649 Apps with dependencies to Microsft\_\_EXCLUDE\_ apps fails deployment