Please add `Automatic-Module-Name`

[sin-ack]

Java 9 introduced modules. To depend on non-module code from modules, there are two options:

• JAR includes Automatic-Module-Name in its META-INF/MANIFEST.MF
• Name autogenerated from the filename

The latter is obviously not great because it can change at any time. Please add the Automatic-Module-Name entry to the JARs published from this project.

More information: http://branchandbound.net/blog/java/2017/12/automatic-module-name/

[jamezp]

@jclingan @Emily-Jiang IMO this should be closed. This may be a bot.

That said, I do see some value in having a module-info.class, in which case we could create a new issue.

[starksm64]

Jakarta specs had already established that a module-info.class is required for every spec api jar. The same should be done for the MP specs, and will be required if they are merged into Jakarta.

…

On Tue, May 13, 2025 at 11:28 AM James R. Perkins ***@***.***> wrote: *jamezp* left a comment (microprofile/microprofile-rest-client#397) <#397 (comment)> @jclingan <https://github.com/jclingan> @Emily-Jiang <https://github.com/Emily-Jiang> IMO this should be closed. This may be a bot. That said, I do see some value in having a module-info.class, in which case we could create a new issue. — Reply to this email directly, view it on GitHub <#397 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACRDMVPUMDX3XCHYNLEDET26ITTLAVCNFSM6AAAAAB5A6ABLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNZXGQYDEMJRGQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.*** com>

[sin-ack]

@jclingan @Emily-Jiang IMO this should be closed. This may be a bot.

That said, I do see some value in having a module-info.class, in which case we could create a new issue.

What? I'm not a bot. Check my activity if you'd like. What made you say that?

[jamezp]

My apologies :) I just assumed based on your profile bio and there was another similar issue filed.

FWIW though I think we need a module-info.java instead of an automatic module name.

[sin-ack]

No worries. Either one is fine with me, as long as I can reference it with a requires. Should I update the issue title?

[dmlloyd]

Any progress on this?

[jamezp]

I think we should just add a module-info.java instead of a Automatic-Module-Name. I'm not sure when I'd find time to create a PR for this, but I don't think it will be soon :)

[dmlloyd]

You can't "just" add a module-info.java now, unfortunately:

• Add automatic module name microprofile-config#810 has to be merged, released, and used first
• Checkstyle chokes on module-info presently
• The test suite defines services in the same module for testing, so it would have to be modified to replace the module descriptor, or else test using a different strategy somehow

So, for now, an automatic module name is appropriate and should be made a priority.

For the record, here's how a proper descriptor would look:

/*
 *******************************************************************************
 * Copyright (c) 2026 Contributors to the Eclipse Foundation
 *
 * See the NOTICE file(s) distributed with this work for additional
 * information regarding copyright ownership.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * You may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *******************************************************************************/

module org.eclipse.microprofile.rest.client {
    requires jakarta.annotation;
    requires jakarta.cdi;
    requires jakarta.inject;
    requires jakarta.ws.rs;

    requires java.logging;

    requires org.eclipse.microprofile.config;

    requires static org.osgi.annotation.versioning;

    uses org.eclipse.microprofile.rest.client.spi.RestClientBuilderResolver;
    uses org.eclipse.microprofile.rest.client.spi.RestClientBuilderListener;
}

Note that org.osgi.annotation.versioning is an automatic module without a specified name, but it was designed to have its file name be the same as its valid module name, so it works out. I imagine this was intentional.

In the meantime I'm happy to provide a PR for the automatic module name, and someone can come back to do this later.