Parentheses are not treated as literal characters

[sapphi-red]

For the following script,

import picomatch from 'picomatch';

console.log('# glob="/foo/(a)", target="/foo/a"');
console.log(
  'without extglob (expected: false)',
  picomatch('/foo/(a)', { noextglob: true })('/foo/a')
);
console.log(
  'with extglob (expected: false)',
  picomatch('/foo/(a)', { noextglob: false })('/foo/a')
);
console.log();

console.log('# glob="/foo/(a)?", target="/foo/a"');
console.log(
  'without extglob (expected: false)',
  picomatch('/foo/(a)?', { noextglob: true })('/foo/a')
);
console.log(
  'with extglob (expected: false)',
  picomatch('/foo/(a)?', { noextglob: false })('/foo/a')
);
console.log();

I get the following output:

# glob="/foo/(a)", target="/foo/a"
without extglob (expected: false) true
with extglob (expected: false) true

# glob="/foo/(a)?", target="/foo/a"
without extglob (expected: false) true
with extglob (expected: false) true

All returns true but I think they should return false because ( and ) doesn't have a special meaning (without prefixes like ? for extglobs).
(stackblitz)

I also tested with bash 5.2.21 and it had the behavior I expected.

[jonschlinkert]

Hi @sapphi-red, thanks for the issue. See https://github.com/micromatch/picomatch#matching-special-characters-as-literals.

[sapphi-red]

Ah, I didn't notice that to include the cases where it doesn't have the special meanings.

[sapphi-red]

How about this one?

console.log('# glob="/foo/(a|b)", target="/foo/a"');
console.log(
  'without extglob (expected: false)',
  picomatch('/foo/(a|b)', { noextglob: true })('/foo/a')
);
console.log(
  'with extglob (expected: false)',
  picomatch('/foo/(a|b)', { noextglob: false })('/foo/a')
);

# glob="/foo/(a|b)", target="/foo/a"
without extglob (expected: false) true
with extglob (expected: false) true

Is this also expected?

[doowb]

Is this also expected?

Yes, these are regex capture groups, not extglobs.

[sapphi-red]

Ah, I didn't notice that this meant that:
https://github.com/micromatch/picomatch/tree/master#library-comparisons:~:text=Regular%20expression%20syntax