Skip to content

Commit c38f0bb

Browse files
authored
Add missing dependencies for release tooling (#134)
A few dependencies slipped through the cracks when migrating to pnpm: #132
2 parents d8cb6d0 + d0d33fd commit c38f0bb

File tree

5 files changed

+38
-61
lines changed

5 files changed

+38
-61
lines changed

.github/workflows/TestPWTCommands.yml

Lines changed: 16 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,21 @@ name: Script tests
22

33
on:
44
push:
5-
branches: [master]
5+
branches:
6+
- master
7+
paths:
8+
- 'pnpm-lock.yaml'
9+
- 'packages/generator-widget/**'
10+
- 'packages/pluggable-widgets-tools/**'
11+
- 'packages/command-tests/**'
612
pull_request:
7-
branches: [master]
13+
branches:
14+
- master
15+
paths:
16+
- 'pnpm-lock.yaml'
17+
- 'packages/generator-widget/**'
18+
- 'packages/pluggable-widgets-tools/**'
19+
- 'packages/command-tests/**'
820

921
jobs:
1022
test:
@@ -20,28 +32,6 @@ jobs:
2032
with:
2133
submodules: false
2234

23-
- name: "Checking changed files"
24-
id: filter
25-
uses: dorny/paths-filter@4512585405083f25c027a35db413c2b3b9006d50 # v2.11.1
26-
if: github.event_name == 'pull_request'
27-
with:
28-
filters: |
29-
packages:
30-
- 'packages/generator-widget/*'
31-
- 'packages/pluggable-widgets-tools/*'
32-
tests:
33-
- 'packages/command-tests/*'
34-
env:
35-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
36-
37-
- name: "Defining cache"
38-
uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
39-
env:
40-
cache-name: cache-node-modules
41-
with:
42-
path: ~/.pnpm-store
43-
key: ${{ runner.os }}-${{ matrix.node }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
44-
4535
- name: Setup pnpm
4636
uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda #v4.1.0
4737
if: matrix.node == 16
@@ -60,14 +50,12 @@ jobs:
6050
cache: 'pnpm'
6151

6252
- name: "Installing dependencies"
63-
if: steps.filter.outputs.packages == 'true' || steps.filter.outputs.tests == 'true'
6453
run: pnpm install
6554

6655
- name: Increase number of watchers
67-
if: (steps.filter.outputs.packages == 'true' || steps.filter.outputs.tests == 'true') && startsWith(matrix.os, 'ubuntu')
56+
if: startsWith(matrix.os, 'ubuntu')
6857
run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
6958

7059
- name: "Testing PWT commands"
7160
working-directory: ./packages/command-tests
72-
if: steps.filter.outputs.packages == 'true' || steps.filter.outputs.tests == 'true'
73-
run: pnpm test
61+
run: pnpm start

.github/workflows/UnitTests.yml

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,14 @@ name: Run unit tests
33
on:
44
push:
55
branches: [master]
6+
paths:
7+
- 'pnpm-lock.yaml'
8+
- 'packages/**'
69
pull_request:
710
branches: [master]
11+
paths:
12+
- 'pnpm-lock.yaml'
13+
- 'packages/**'
814

915
jobs:
1016
test:
@@ -17,25 +23,6 @@ jobs:
1723
with:
1824
submodules: false
1925

20-
- name: "Checking changed files"
21-
id: filter
22-
uses: dorny/paths-filter@4512585405083f25c027a35db413c2b3b9006d50 # v2.11.1
23-
if: github.event_name == 'pull_request'
24-
with:
25-
filters: |
26-
packages:
27-
- 'packages/**/*'
28-
env:
29-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
30-
31-
- name: "Defining cache"
32-
uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
33-
env:
34-
cache-name: cache-node-modules
35-
with:
36-
path: ~/.pnpm-store
37-
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
38-
3926
- name: Setup pnpm
4027
uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda #v4.1.0
4128
with:
@@ -48,14 +35,11 @@ jobs:
4835
cache: 'pnpm'
4936

5037
- name: "Installing dependencies"
51-
if: steps.filter.outputs.packages == 'true'
5238
run: pnpm install
5339

5440
- name: "Running unit tests"
55-
if: steps.filter.outputs.packages == 'true'
5641
run: pnpm -r test
5742

58-
- name: "Linting generator-widget"
43+
- name: "Linting packages"
5944
working-directory: ./packages/generator-widget
60-
if: steps.filter.outputs.packages == 'true'
61-
run: pnpm run lint
45+
run: pnpm -r lint

packages/command-tests/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"private": true,
66
"main": "commands.js",
77
"scripts": {
8-
"test": "node commands.js"
8+
"start": "node commands.js"
99
},
1010
"devDependencies": {
1111
"@prettier/plugin-xml": "^2.2.0",

packages/release-tools/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
},
1313
"devDependencies": {
1414
"@types/node": "^16.11.19",
15+
"@types/node-fetch": "2.6.1",
1516
"@typescript-eslint/eslint-plugin": "^5.40.1",
17+
"@typescript-eslint/parser": "^5.62.0",
1618
"eslint": "^8.25.0",
1719
"eslint-config-prettier": "^8.5.0",
1820
"eslint-plugin-prettier": "^4.2.1",

pnpm-lock.yaml

Lines changed: 11 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)