Update build tooling from starter template and fix linter issues (#964)

* Update build tooling from starter template and fix linter issues

- Update Go version from 1.24.6 to 1.24.11
- Update golangci-lint to v2.8.0 with new config format
- Update gotestsum to v1.13.0
- Update Node.js version from 16.13.1 to 20.11
- Add manifest-check target to Makefile
- Use Go 1.24 features (strings.SplitSeq, slices.Contains)
- Replace interface{} with any throughout codebase
- Replace custom contains functions with slices.Contains
- Convert if-else chains to tagged switches
- Simplify embedded field selectors (c.Context.Ctx → c.Ctx)
- Use strings.Builder for efficient string concatenation
- Apply De Morgan's law simplifications
- Fix directory permissions (0755 → 0750)
- Add license headers to build files

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Restore omitempty on DefaultRepo field

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Use omitzero instead of omitempty for DefaultRepo struct field

omitempty has no effect on non-pointer struct fields in JSON encoding.
Go 1.24's omitzero correctly omits the field when the struct is its
zero value.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Update Go to 1.25, golangci-lint to 2.9, and remove golang-version from CI

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Use WaitGroup.Go to simplify goroutine creation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: hanzei

.editorconfig

@@ -18,7 +18,7 @@ indent_size = 4
 [webapp/package.json]
 indent_size = 2
 
-[Makefile,*.mk]
+[{Makefile,*.mk}]
 indent_style = tab
 
 [*.md]

.github/workflows/ci.yml

@@ -17,5 +17,3 @@ jobs:
   plugin-ci:
     uses: mattermost/actions-workflows/.github/workflows/plugin-ci.yml@main
     secrets: inherit
-    with:
-      golang-version: "1.24.6"

.gitignore

@@ -1,4 +1,3 @@
-node_modules
 bin/
 dist/
 webapp/src/manifest.ts

.golangci.yml

@@ -1,122 +1,62 @@
-version: 2
+version: "2"
 
 run:
   timeout: 5m
   modules-download-mode: readonly
 
-linters-settings:
-  goconst:
-    min-len: 3
-    min-occurrences: 2
-  gofmt:
-    simplify: true
-  goimports:
-    local-prefixes: github.com/mattermost/mattermost-plugin-github
-  govet:
-    enable-all: true
-    disable:
-      - fieldalignment
-  misspell:
-    locale: US
-  revive:
-
 linters:
-  disable-all: true
+  default: none
   enable:
+    - bidichk
     - bodyclose
     - errcheck
     - gocritic
     - gosec
     - govet
     - ineffassign
+    - makezero
     - misspell
+    - modernize
     - nakedret
     - revive
     - staticcheck
     - unconvert
+    - unqueryvet
     - unused
     - whitespace
+  settings:
+    govet:
+      enable-all: true
+      disable:
+        - fieldalignment
+    revive:
+      rules:
+        - name: exported
+          disabled: true
+        - name: unused-parameter
+          disabled: true
+    unqueryvet:
+      check-sql-builders: true
   exclusions:
     rules:
-      - linters:
-          - revive
-        text: var-naming|error-naming|exported|increment-decrement|error-strings|if-return|unused-parameter|blank-imports|empty-block|package-comments
-      - linters:
-          - errcheck
-        text: Error return value
-      - linters:
-          - staticcheck
-        text: SA1019
-      - linters:
-          - staticcheck
-        text: ST1023
-      - linters:
-          - staticcheck
-        text: ST1012
-      - linters:
-          - staticcheck
-        text: ST1005
-      - linters:
-          - staticcheck
-        text: QF1011
-      - linters:
-          - staticcheck
-        text: QF1001
-      - linters:
-          - staticcheck
-        text: QF1003
-      - linters:
-          - staticcheck
-        text: QF1012
-      - linters:
-          - staticcheck
-        text: QT1019
-      - linters:
-          - staticcheck
-        text: QF1008
-      - linters:
-          - staticcheck
-        text: QF1004
-      - linters:
-          - staticcheck
-        text: ST1019
-      - linters:
-          - staticcheck
-        text: QF1006
-      - linters:
-          - staticcheck
-        text: QF1002
-      - linters:
-          - staticcheck
-        text: QF1007
-      - linters:
-          - gosec
-        text: G104
-      - linters:
-          - gosec
-        text: G304
-      - linters:
-          - gosec
-        text: G301
+      - path: server/configuration.go
+        linters:
+          - unused
+      - path: _test\.go
+        linters:
+          - bodyclose
 
 formatters:
-  disable-all: true
   enable:
     - gofmt
+    - gofumpt
     - goimports
-
-issues:
-  exclude-rules:
-    - path: server/manifest.go
-      linters:
-        - deadcode
-        - unused
-        - varcheck
-    - path: server/configuration.go
-      linters:
-        - unused
-    - path: _test\.go
-      linters:
-        - bodyclose
-        - goconst
-        - scopelint # https://github.com/kyoh86/scopelint/issues/4
+  settings:
+    gofmt:
+      simplify: true
+      rewrite-rules:
+        - pattern: interface{}
+          replacement: any
+    goimports:
+      local-prefixes:
+        - github.com/mattermost/mattermost-plugin-github

Makefile

@@ -170,6 +170,11 @@ major-rc: ## to bump major release candidate version (semver)
 .PHONY: all
 all: check-style test dist
 
+## Ensures the plugin manifest is valid
+.PHONY: manifest-check
+manifest-check:
+	./build/bin/manifest check
+
 ## Propagates plugin manifest information into the server/ and webapp/ folders.
 .PHONY: apply
 apply:
@@ -178,13 +183,14 @@ apply:
 ## Install go tools
 install-go-tools:
 	@echo Installing go tools
-	$(GO) install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.6.0
-	$(GO) install gotest.tools/gotestsum@v1.7.0
+	$(GO) install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.9.0
+	$(GO) install gotest.tools/gotestsum@v1.13.0
+
 	$(GO) install github.com/mattermost/mattermost-govet/v2@7d8db289e508999dfcac47b97c9490a0fec12d66
 
 ## Runs eslint and golangci-lint
 .PHONY: check-style
-check-style: apply webapp/node_modules install-go-tools
+check-style: manifest-check apply webapp/node_modules install-go-tools
 	@echo Checking for style guide compliance
 
 ifneq ($(HAS_WEBAPP),)
@@ -362,7 +368,7 @@ endif
 .PHONY: coverage
 coverage: apply webapp/node_modules
 ifneq ($(HAS_SERVER),)
-	$(GO) test $(GO_TEST_FLAGS) -coverprofile=server/coverage.txt ./...
+	$(GO) test $(GO_TEST_FLAGS) -coverprofile=server/coverage.txt ./server/...
 	$(GO) tool cover -html=server/coverage.txt
 endif
 

build/manifest/main.go

@@ -10,9 +10,8 @@ import (
 	"os"
 	"strings"
 
-	"github.com/pkg/errors"
-
 	"github.com/mattermost/mattermost/server/public/model"
+	"github.com/pkg/errors"
 )
 
 const pluginIDGoFileTemplate = `// This file is automatically generated. Do not modify it manually.
@@ -91,6 +90,11 @@ func main() {
 			panic("failed to write manifest to dist directory: " + err.Error())
 		}
 
+	case "check":
+		if err := manifest.IsValid(); err != nil {
+			panic("failed to check manifest: " + err.Error())
+		}
+
 	default:
 		panic("unrecognized command: " + cmd)
 	}
@@ -101,11 +105,11 @@ func findManifest() (*model.Manifest, error) {
 	if err != nil {
 		return nil, errors.Wrap(err, "failed to find manifest in current working directory")
 	}
-	manifestFile, err := os.Open(manifestFilePath)
+	manifestFile, err := os.Open(manifestFilePath) //nolint:gosec
 	if err != nil {
 		return nil, errors.Wrapf(err, "failed to open %s", manifestFilePath)
 	}
-	defer manifestFile.Close()
+	defer func() { _ = manifestFile.Close() }()
 
 	// Re-decode the manifest, disallowing unknown fields. When we write the manifest back out,
 	// we don't want to accidentally clobber anything we won't preserve.
@@ -120,8 +124,8 @@ func findManifest() (*model.Manifest, error) {
 	// commit, and use the first version we find (to prevent causing errors)
 	if manifest.Version == "" {
 		var version string
-		tags := strings.Fields(BuildTagCurrent)
-		for _, t := range tags {
+		tags := strings.FieldsSeq(BuildTagCurrent)
+		for t := range tags {
 			if strings.HasPrefix(t, "v") {
 				version = t
 				break
@@ -139,10 +143,11 @@ func findManifest() (*model.Manifest, error) {
 
 	// If no release notes specified, generate one from the latest tag, if present.
 	if manifest.ReleaseNotesURL == "" && BuildTagLatest != "" {
-		manifest.ReleaseNotesURL, err = url.JoinPath(manifest.HomepageURL, "releases", "tag", BuildTagLatest)
+		releaseNotesURL, err := url.JoinPath(manifest.HomepageURL, "releases", "tag", BuildTagLatest)
 		if err != nil {
-			return nil, errors.Wrap(err, "failed to generate release notes URL")
+			return nil, errors.Wrap(err, "failed to build release notes URL")
 		}
+		manifest.ReleaseNotesURL = releaseNotesURL
 	}
 
 	return &manifest, nil
@@ -171,8 +176,8 @@ func applyManifest(manifest *model.Manifest) error {
 		// write generated code to file by using Go file template.
 		if err := os.WriteFile(
 			"server/plugin/manifest.go",
-			[]byte(fmt.Sprintf(pluginIDGoFileTemplate, manifestStr)),
-			0600,
+			fmt.Appendf(nil, pluginIDGoFileTemplate, manifestStr),
+			0o600,
 		); err != nil {
 			return errors.Wrap(err, "failed to write server/plugin/manifest.go")
 		}
@@ -194,8 +199,8 @@ func applyManifest(manifest *model.Manifest) error {
 		// write generated code to file by using JS file template.
 		if err := os.WriteFile(
 			"webapp/src/manifest.ts",
-			[]byte(fmt.Sprintf(pluginIDJSFileTemplate, manifestStr)),
-			0600,
+			fmt.Appendf(nil, pluginIDJSFileTemplate, manifestStr),
+			0o600,
 		); err != nil {
 			return errors.Wrap(err, "failed to open webapp/src/manifest.ts")
 		}
@@ -211,7 +216,7 @@ func distManifest(manifest *model.Manifest) error {
 		return err
 	}
 
-	if err := os.WriteFile(fmt.Sprintf("dist/%s/plugin.json", manifest.Id), manifestBytes, 0600); err != nil {
+	if err := os.WriteFile(fmt.Sprintf("dist/%s/plugin.json", manifest.Id), manifestBytes, 0o600); err != nil {
 		return errors.Wrap(err, "failed to write plugin.json")
 	}
 

build/pluginctl/logs.go

@@ -181,7 +181,7 @@ func checkJSONLogsSetting(ctx context.Context, client *model.Client4) error {
 		return fmt.Errorf("failed to fetch config: %w", err)
 	}
 	if cfg.LogSettings.FileJson == nil || !*cfg.LogSettings.FileJson {
-		return errors.New("JSON output for file logs are disabled. Please enable LogSettings.FileJson via the configuration in Mattermost.") //nolint:revive,stylecheck
+		return errors.New("JSON output for file logs is disabled, please enable LogSettings.FileJson via the configuration in Mattermost")
 	}
 
 	return nil

build/pluginctl/main.go

@@ -128,11 +128,11 @@ func getUnixClient(socketPath string) (*model.Client4, bool) {
 // deploy attempts to upload and enable a plugin via the Client4 API.
 // It will fail if plugin uploads are disabled.
 func deploy(ctx context.Context, client *model.Client4, pluginID, bundlePath string) error {
-	pluginBundle, err := os.Open(bundlePath)
+	pluginBundle, err := os.Open(bundlePath) //nolint:gosec
 	if err != nil {
 		return fmt.Errorf("failed to open %s: %w", bundlePath, err)
 	}
-	defer pluginBundle.Close()
+	defer func() { _ = pluginBundle.Close() }()
 
 	log.Print("Uploading plugin via API.")
 	_, _, err = client.UploadPluginForced(ctx, pluginBundle)

build/setup.mk

@@ -1,5 +1,3 @@
-GO_BUILD_FLAGS ?=
-
 # Ensure that go is installed. Note that this is independent of whether or not a server is being
 # built, since the build script itself uses go.
 ifeq ($(GO),)

client/client.go

@@ -74,7 +74,7 @@ func (c *Client) GetConfiguration() (*plugin.Configuration, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	respBody, err := io.ReadAll(resp.Body)
 	if err != nil {
@@ -111,7 +111,7 @@ func (c *Client) GetToken(userID string) (*oauth2.Token, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	respBody, err := io.ReadAll(resp.Body)
 	if err != nil {