Fix NameError by using existing SIZE_2_8_INCH_NEWREV constant#1005
Open
wyldere wants to merge 1 commit into
Open
Fix NameError by using existing SIZE_2_8_INCH_NEWREV constant#1005wyldere wants to merge 1 commit into
wyldere wants to merge 1 commit into
Conversation
wyldere
force-pushed
the
fix-size-2-8-round-usb-constant
branch
from
500387e to
bbd56c5
Compare
Owner
|
Sorry for that, the |
wyldere
force-pushed
the
fix-size-2-8-round-usb-constant
branch
from
bbd56c5 to
81cf8da
Compare
Author
|
Thanks for the review. Updated to use |
wyldere
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit a3a375d (PR #995) referenced SIZE_2_8_ROUND_USB in five places
in configure.py but never defined the constant, causing a NameError at
import time. This adds the missing definition.