Unnecessary references in Mediator.Abstractions when targeting netstandard2.0

[PatrykPlewaOfficial]

The package Mediator.Abstractions (Mediator.csproj) has unnecessary references to the following NuGet packages:

• Microsoft.Extensions.DependencyInjection.Abstractions
• System.Collections.Immutable
• System.Runtime.CompilerServices.Unsafe

These transient dependencies cause issues when installing the Mediator.Abstractions package in older projects where the Mediator package officially is supposed to support netstandard2.0.

Code builds perfectly without these dependencies, for all targets. That will leave us with only Microsoft.Bcl.AsyncInterfaces.

Please remove them in the nearest version. I can also help with a quick PR if desired.

[martinothamar]

Which version of .NET are you on? The idea was that it would bring in also what is needed from the generated code, which does reference types from these packages. Maybe that's the wrong approach?

The samples/basic/NetFramework sample breaks if I remove them.

[PatrykPlewaOfficial]

Thank you for the prompt answer.

I did not see any errors because the samples/basic/NetFramework is not added to the main solution file.

I have .NET 10.0.0.100 SDK installed.

The samples/basic/NetFramework sample breaks for a different reason. Indeed, it is the generated code that does not compile anymore.

Here are the compilation errors:

• The type or namespace name 'IServiceCollection' could not be found
• The type 'ValueTask<>' is defined in an assembly that is not referenced
• The type 'IAsyncEnumerable<>' is defined in an assembly that is not referenced
• The type or namespace name 'ServiceLifetime' does not exist in the namespace 'Microsoft.Extensions.DependencyInjection'

Here are my observations:

1. Microsoft.Extensions.DependencyInjection.Abstractions does not seem necessary in Mediator.Abstractions. It's the Mediator.SourceGenerator that needs it, and sometimes the end-projects like consoles/APIs.
2. I did not find any use cases for the System.Collections.Immutable in Mediator.Abstractions. Maybe it could be moved to Mediator.SourceGenerator.
3. Microsoft.Bcl.AsyncInterfaces must stay. I forgot about the IAsyncEnumerable used, for example, in IStreamPipelineBehavior.
4. I'm not sure what about System.Runtime.CompilerServices.Unsafe yet. Maybe it would need to be replaced with System.Threading.Tasks.Extensions (which has a transient reference to System.Runtime.CompilerServices.Unsafe anyway) to use ValueTask<>

Let me know what you think. I'm not an expert in Source Code Generators. Perhaps I'm missing something.