Fix CQS signal facebook-hte-UnqualifiedCall-sqrt in fbcode/mapillary/opensfm

generatedunixname1435320781521086 · meta-codesync[bot] · commit c3c0453289a5 · 2026-02-05T04:35:56.000-08:00
Differential Revision: D92372593

fbshipit-source-id: b3b18a93eb94f2a353632aa9846ec804cbce6623
diff --git a/opensfm/src/dense/src/depthmap.cc b/opensfm/src/dense/src/depthmap.cc
@@ -69,7 +69,7 @@ float NCCEstimator::Get() {
   if (varx < 0.1 || vary < 0.1) {
     return -1;
   } else {
-    return (meanxy - meanx * meany) / sqrt(varx * vary);
+    return (meanxy - meanx * meany) / std::sqrt(varx * vary);
   }
 }
 
diff --git a/opensfm/src/features/src/hahog.cc b/opensfm/src/features/src/hahog.cc
@@ -173,7 +173,7 @@ py::tuple hahog(foundation::pyarray_f image, float peak_threshold,
     for (i = 0; i < (signed)numFeatures; ++i) {
       const VlFrameOrientedEllipse& frame = vecFeatures.at(i).frame;
       float det = frame.a11 * frame.a22 - frame.a12 * frame.a21;
-      float size = sqrt(fabs(det));
+      float size = std::sqrt(fabs(det));
       float angle = atan2(frame.a21, frame.a11) * 180.0f / M_PI;
       points[4 * i + 0] = frame.x;
       points[4 * i + 1] = frame.y;
diff --git a/opensfm/src/features/src/matching.cc b/opensfm/src/features/src/matching.cc
@@ -28,7 +28,7 @@ float DistanceL2(const float* pa, const float* pb, int n) {
   for (int i = 0; i < n; ++i) {
     distance += (pa[i] - pb[i]) * (pa[i] - pb[i]);
   }
-  return sqrt(distance);
+  return std::sqrt(distance);
 }
 
 void MatchUsingWords(const cv::Mat& f1, const cv::Mat& w1, const cv::Mat& f2,

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ float NCCEstimator::Get() {`
`69`	`69`	`if (varx < 0.1 \|\| vary < 0.1) {`
`70`	`70`	`return -1;`
`71`	`71`	`} else {`
`72`		`- return (meanxy - meanx * meany) / sqrt(varx * vary);`
	`72`	`+ return (meanxy - meanx * meany) / std::sqrt(varx * vary);`
`73`	`73`	`}`
`74`	`74`	`}`
`75`	`75`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ float DistanceL2(const float* pa, const float* pb, int n) {`
`28`	`28`	`for (int i = 0; i < n; ++i) {`
`29`	`29`	`distance += (pa[i] - pb[i]) * (pa[i] - pb[i]);`
`30`	`30`	`}`
`31`		`- return sqrt(distance);`
	`31`	`+ return std::sqrt(distance);`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`void MatchUsingWords(const cv::Mat& f1, const cv::Mat& w1, const cv::Mat& f2,`