Fix CQS signal facebook-hte-ConstantArgumentPassByValue in fbcode/mapillary/opensfm

generatedunixname89002005287564 · meta-codesync[bot] · commit 7168049892d1 · 2026-01-21T01:26:47.000-08:00
Differential Revision: D91019840

fbshipit-source-id: 17467a7ac65b31756f5e1b978e91f82c9fa71e06
diff --git a/opensfm/src/bundle/error/error_utils.h b/opensfm/src/bundle/error/error_utils.h
@@ -85,7 +85,7 @@ void WorldToCameraCoordinatesRig(const T* scale, const T* const rig_instance,
 }
 
 template <typename T>
-T DiffBetweenAngles(const T a, const T b) {
+T DiffBetweenAngles(const T& a, const T& b) {
   T d = a - b;
   if (d > T(M_PI)) {
     return d - T(2 * M_PI);
diff --git a/opensfm/src/map/rig.h b/opensfm/src/map/rig.h
@@ -41,7 +41,7 @@ class RigInstance {
   map::RigInstanceId id;
 
   RigInstance() = default;
-  explicit RigInstance(const RigInstanceId instance_id) : id(instance_id) {}
+  explicit RigInstance(const RigInstanceId& instance_id) : id(instance_id) {}
 
   // Getters
   const std::unordered_map<map::ShotId, map::Shot*>& GetShots() const {

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ void WorldToCameraCoordinatesRig(const T* scale, const T* const rig_instance,`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`template <typename T>`
`88`		`-T DiffBetweenAngles(const T a, const T b) {`
	`88`	`+T DiffBetweenAngles(const T& a, const T& b) {`
`89`	`89`	`T d = a - b;`
`90`	`90`	`if (d > T(M_PI)) {`
`91`	`91`	`return d - T(2 * M_PI);`