Fix potential null pointer deference, closing issue #332

jiegec · jiegec · commit 15646aae742e · 2025-06-28T16:10:02.000+08:00
diff --git a/lib/dialects/linux/dproc.c b/lib/dialects/linux/dproc.c
@@ -1273,7 +1273,7 @@ static int process_id(struct lsof_context *ctx, /* context */
 #endif     /* defined(HASEPTOPTS) */
                 if (rest && rest[0] == '[' && rest[1] == 'p')
                     fdinfo_mask |= FDINFO_PID;
-                else if (Lf->ntype == N_REGLR && rest && *rest && strcmp(pbuf, "pidfd") == 0) {
+                else if (Lf && Lf->ntype == N_REGLR && rest && *rest && strcmp(pbuf, "pidfd") == 0) {
                     // https://github.com/lsof-org/lsof/issues/317
                     fdinfo_mask |= FDINFO_PID;
                 }

Original file line number	Diff line number	Diff line change
`@@ -1273,7 +1273,7 @@ static int process_id(struct lsof_context ctx, / context */`
`1273`	`1273`	`#endif /* defined(HASEPTOPTS) */`
`1274`	`1274`	`if (rest && rest[0] == '[' && rest[1] == 'p')`
`1275`	`1275`	`fdinfo_mask \|= FDINFO_PID;`
`1276`		`- else if (Lf->ntype == N_REGLR && rest && *rest && strcmp(pbuf, "pidfd") == 0) {`
	`1276`	`+ else if (Lf && Lf->ntype == N_REGLR && rest && *rest && strcmp(pbuf, "pidfd") == 0) {`
`1277`	`1277`	`// https://github.com/lsof-org/lsof/issues/317`
`1278`	`1278`	`fdinfo_mask \|= FDINFO_PID;`
`1279`	`1279`	`}`