Skip to content

Question: benefit to using distance matrix? #2

@alexvpickering

Description

@alexvpickering

Hi I noticed that to_graph in dataset/get_qm8_data.py doesn't use the 7th channel (distance matrix). I presume this is related to this line in your paper:

Since some models cannot leverage feature on edges easily, we use the molecule graph itself as the only input information for all models so that it is a fair comparison.

I am wondering if you have tried including the 7th channel (or if it is even valid to do so)? So to_graph would return:

...
# return atom_feat, pair_feat[:, :, :6]
return atom_feat, pair_feat[:, :, :7]

If so, what would you suggest for generating distance matrices for other molecules (not from QM8 dataset)? Is AllChem.EmbedMolecule reasonable? Thank you for making your code available!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions