fix phpstan performance issues

Author: lode

tests/profiles/CursorPaginationProfileTest.php

@@ -76,21 +76,30 @@ public function test_WithRelationship(): void {
 		parent::assertArrayHasKey('data', $array);
 		parent::assertArrayHasKey('relationships', $array['data']);
 		parent::assertArrayHasKey('people', $array['data']['relationships']);
-		parent::assertArrayHasKey('links', $array['data']['relationships']['people']);
-		parent::assertArrayHasKey('data', $array['data']['relationships']['people']);
-		parent::assertArrayHasKey('meta', $array['data']['relationships']['people']);
-		parent::assertArrayHasKey('prev', $array['data']['relationships']['people']['links']);
-		parent::assertArrayHasKey('next', $array['data']['relationships']['people']['links']);
-		parent::assertArrayHasKey('page', $array['data']['relationships']['people']['meta']);
-		parent::assertArrayHasKey('href', $array['data']['relationships']['people']['links']['prev']);
-		parent::assertArrayHasKey('href', $array['data']['relationships']['people']['links']['next']);
-		parent::assertArrayHasKey('total', $array['data']['relationships']['people']['meta']['page']);
-		parent::assertArrayHasKey('estimatedTotal', $array['data']['relationships']['people']['meta']['page']);
-		parent::assertArrayHasKey('bestGuess', $array['data']['relationships']['people']['meta']['page']['estimatedTotal']);
-		parent::assertCount(3, $array['data']['relationships']['people']['data']);
-		parent::assertArrayHasKey('meta', $array['data']['relationships']['people']['data'][0]);
-		parent::assertArrayHasKey('page', $array['data']['relationships']['people']['data'][0]['meta']);
-		parent::assertArrayHasKey('cursor', $array['data']['relationships']['people']['data'][0]['meta']['page']);
+		
+		// re-map nested arrays to variables to speed up phpstan
+		// without it, this file takes 10 seconds (!) more to process
+		
+		$people = $array['data']['relationships']['people'];
+		parent::assertArrayHasKey('links', $people);
+		parent::assertArrayHasKey('data', $people);
+		parent::assertArrayHasKey('meta', $people);
+		parent::assertArrayHasKey('prev', $people['links']);
+		parent::assertArrayHasKey('next', $people['links']);
+		parent::assertArrayHasKey('page', $people['meta']);
+		parent::assertArrayHasKey('href', $people['links']['prev']);
+		parent::assertArrayHasKey('href', $people['links']['next']);
+		
+		$peopleMeta = $people['meta'];
+		parent::assertArrayHasKey('total', $peopleMeta['page']);
+		parent::assertArrayHasKey('estimatedTotal', $peopleMeta['page']);
+		parent::assertArrayHasKey('bestGuess', $peopleMeta['page']['estimatedTotal']);
+		parent::assertCount(3, $people['data']);
+		
+		$firstPerson = $people['data'][0];
+		parent::assertArrayHasKey('meta', $firstPerson);
+		parent::assertArrayHasKey('page', $firstPerson['meta']);
+		parent::assertArrayHasKey('cursor', $firstPerson['meta']['page']);
 	}
 
 	public function testSetLinksFirstPage_HappyPath(): void {