Skip to content

Commit b6bd036

Browse files
committed
Added todo
1 parent 1c50813 commit b6bd036

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

livekit/sip.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -394,12 +394,12 @@ func (p *SIPInboundTrunkInfo) Validate() error {
394394
}
395395
if err := validateHeaders(p.Headers); err != nil {
396396
logger.Warnw("Header validation failed for Headers field", err)
397-
// No error, just a warning for SIP RFC validation for now
397+
// TODO: Once we're happy with the validation, we want this to error out
398398
}
399399
// Don't bother with HeadersToAttributes. If they're invalid, we just won't match
400400
if err := validateHeaderNames(p.AttributesToHeaders); err != nil {
401401
logger.Warnw("Header validation failed for AttributesToHeaders field", err)
402-
// No error, just a warning for SIP RFC validation for now
402+
// TODO: Once we're happy with the validation, we want this to error out
403403
}
404404
return nil
405405
}
@@ -490,12 +490,12 @@ func (p *SIPOutboundTrunkInfo) Validate() error {
490490
}
491491
if err := validateHeaders(p.Headers); err != nil {
492492
logger.Warnw("Header validation failed for Headers field", err)
493-
// No error, just a warning for SIP RFC validation for now
493+
// TODO: Once we're happy with the validation, we want this to error out
494494
}
495495
// Don't bother with HeadersToAttributes. If they're invalid, we just won't match
496496
if err := validateHeaderNames(p.AttributesToHeaders); err != nil {
497497
logger.Warnw("Header validation failed for AttributesToHeaders field", err)
498-
// No error, just a warning for SIP RFC validation for now
498+
// TODO: Once we're happy with the validation, we want this to error out
499499
}
500500
return nil
501501
}
@@ -726,7 +726,7 @@ func (p *CreateSIPParticipantRequest) Validate() error {
726726

727727
if err := validateHeaders(p.Headers); err != nil {
728728
logger.Warnw("Header validation failed for Headers field", err)
729-
// No error, just a warning for SIP RFC validation for now
729+
// TODO: Once we're happy with the validation, we want this to error out
730730
}
731731

732732
// Validate display_name if provided
@@ -735,7 +735,7 @@ func (p *CreateSIPParticipantRequest) Validate() error {
735735
return errors.New("display_name too long (max 128 characters)")
736736
}
737737

738-
// TODO: Validate display name doesn't contain invalid characters
738+
// TODO: Once we're happy with the validation, we want this to error out
739739
}
740740

741741
// Validate destination if provided
@@ -829,7 +829,7 @@ func (p *TransferSIPParticipantRequest) Validate() error {
829829

830830
if err := validateHeaders(p.Headers); err != nil {
831831
logger.Warnw("Header validation failed for Headers field", err)
832-
// No error, just a warning for SIP RFC validation for now
832+
// TODO: Once we're happy with the validation, we want this to error out
833833
}
834834

835835
return nil

0 commit comments

Comments
 (0)