shallow object

Author: lukasIO

src/room/Room.ts

@@ -144,7 +144,7 @@ export enum ConnectionState {
 }
 
 const CONNECTION_RECONCILE_FREQUENCY_MS = 4 * 1000;
-const STATS_LOG_FREQUENCY_MS = 30 * 1000;
+const STATS_LOG_FREQUENCY_MS = 5 * 1000;
 
 /**
  * In LiveKit, a room is the logical grouping for a list of participants.
@@ -2616,8 +2616,7 @@ class Room extends (EventEmitter as new () => TypedEmitter<RoomEventCallbacks>)
   }
 
   /**
-   * Dumps the raw stats of both peer connections. They cover every track of the
-   * room as well as the transports, so nothing is collected per track.
+   * Dumps stats of both peer connections.
    */
   private logWebRTCStats = async () => {
     const pcManager = this.engine?.pcManager;
@@ -2629,9 +2628,13 @@ class Room extends (EventEmitter as new () => TypedEmitter<RoomEventCallbacks>)
         pcManager.publisher.getStats(),
         pcManager.subscriber?.getStats(),
       ]);
-      this.statsLog.info('webrtc stats', {
-        publisher: publisher && summarizeStatsReport(publisher),
-        subscriber: subscriber && summarizeStatsReport(subscriber),
+      const publisherStats = publisher && summarizeStatsReport(publisher);
+      const subscriberStats = subscriber && summarizeStatsReport(subscriber);
+      this.statsLog.info(`webrtc stats`, {
+        publisher: publisherStats?.connection,
+        subscriber: subscriberStats?.connection,
+        inbound: [...(publisherStats?.inbound ?? []), ...(subscriberStats?.inbound ?? [])],
+        outbound: publisherStats?.outbound,
       });
     } catch (error) {
       this.statsLog.debug('could not collect webrtc stats', { error });

src/room/statsSummary.ts

@@ -1,7 +1,7 @@
 /** one summarised stats entry; keys without a value are dropped */
 type Summary = Record<string, unknown>;
 
-function compact(summary: Summary): Summary {
+function compact<T extends Summary>(summary: T): Summary {
   const compacted: Summary = {};
   for (const [key, value] of Object.entries(summary)) {
     if (value !== undefined) {
@@ -48,7 +48,7 @@ function playoutDelay(stat: Summary, playout?: Summary): number | undefined {
  * Picks the interesting fields out of a `getStats()` report and groups them by
  * RTP stream, so a stats dump can be read without unfolding the raw report.
  */
-export function summarizeStatsReport(report: RTCStatsReport): Summary {
+export function summarizeStatsReport(report: RTCStatsReport) {
   const byId = new Map<string, Summary>();
   const candidatePairs: Summary[] = [];
   const inbound: Summary[] = [];
@@ -179,9 +179,9 @@ export function summarizeStatsReport(report: RTCStatsReport): Summary {
     candidatePairChanges: transport?.selectedCandidatePairChanges,
   });
 
-  return compact({
+  return {
     connection: Object.keys(connection).length > 0 ? connection : undefined,
     outbound: outbound.length > 0 ? outbound : undefined,
     inbound: inbound.length > 0 ? inbound : undefined,
-  });
+  };
 }