-
Notifications
You must be signed in to change notification settings - Fork 257
Closed
Description
Is there already an issue for this?
- There is no relevant open or closed issue for this
Is this a request for support of a new device?
- This is not a new device request
Is this a support request?
- This is not a support request
Description
With the new Lian Li driver added in #837, the status output labels all the fans as "channels". Because of this, in CoolerControl, I had to write another custom regex pattern to extract fan speed, since Lian Li fans are labeled "channel", whereas all others are labeled "fan". The existing logic there had a pattern for ^fan \d+ speed which covered almost everything except something with Corsair, which has speed and the digit flipped. For the Lian Li driver to be supported, I had to add a pattern for ^channel \d+, which feels wrong. CoolerControl commit for reference.
Should the terminology be changed to match other drivers?
Metadata
Metadata
Assignees
Labels
No labels