fail the role

Author: richm

tasks/main.yml

@@ -42,34 +42,36 @@
 
 - name: Package snapm version must be 0.4 or later
   fail:
-    msg: >
+    msg: >-
       Package snapm version {{ __snapshot_snapm_version }} is too old -
       must be 0.4 or later
   when:
     - __snapshot_snapm_available
     - __snapshot_snapm_version is version("0.4", "<")
 
-- name: Package snapm must available and be version 0.5 or later for bootable snapsets
+- name: Package snapm must available for bootable snapsets
   fail:
-    msg: >
-      Package snapm version {{ __snapshot_snapm_version }} is too old -
-      must be 0.5 or later to use bootable snapsets
+    msg: >-
+      Package snapm version 0.5 or later is required to use bootable snapsets
   when:
-    - not __snapshot_snapm_available or
-      __snapshot_snapm_version is version("0.5", "<")
+    - not __snapshot_snapm_available
     - __snapshot_needs_bootable_support
-    - snapshot_fail_if_too_old | d(true)
 
-- name: Package snapm must available and be version 0.5 or later for bootable snapsets
-  meta: end_host
+- name: Package snapm must be version 0.5 or later for bootable snapsets
+  fail:
+    msg: >-
+      Package snapm version {{ __snapshot_snapm_version }} is too old -
+      version 0.5 or later is required to use bootable snapsets
   when:
     - not __snapshot_snapm_available or
       __snapshot_snapm_version is version("0.5", "<")
     - __snapshot_needs_bootable_support
-    - not snapshot_fail_if_too_old | d(true)
 
 - name: Run snapshot module and handle errors
-  when: snapshot_lvm_action is defined
+  when:
+    - snapshot_lvm_action is defined
+    - not __snapshot_needs_bootable_support or (__snapshot_snapm_available and
+      __snapshot_snapm_version is version("0.5", ">="))
   block:
     - name: Run snapshot module {{ snapshot_lvm_action }}
       snapshot:

tests/tests_set_bootable.yml

@@ -50,7 +50,6 @@
           lv: lv7
           percent_space_required: 15
     snapshot_lvm_bootable: true
-    snapshot_fail_if_too_old: false
   tasks:
     - name: Load test variables
       include_vars:
@@ -121,6 +120,13 @@
         - name: Assert no changes for remove snapset
           assert:
             that: not snapshot_cmd["changed"]
+      rescue:
+        - name: Check if error is due to snapm version too old
+          fail:
+            msg: Unexpected error occurred {{ ansible_failed_result | to_nice_json }}
+          when: not ansible_failed_result.msg is search(err_msg)
+          vars:
+            err_msg: Package snapm .*version 0.5 or later is required to use bootable snapsets
       always:
         - name: Cleanup
           include_tasks: tasks/cleanup.yml