Add icon to Windows build, guard focus stealing.

Author: evoskuil

builds/msvc/libbitcoin.ico

@@ -187,4 +187,7 @@
   <ItemGroup>
     <Natvis Include="..\..\debug.natvis" />
   </ItemGroup>
-</Project>
+  <ItemGroup>
+    <Image Include="..\..\libbitcoin.ico" />
+  </ItemGroup>
+</Project>

builds/msvc/resource.h

@@ -119,4 +119,9 @@
       <Filter>resource</Filter>
     </ResourceCompile>
   </ItemGroup>
-</Project>
+  <ItemGroup>
+    <Image Include="..\..\libbitcoin.ico">
+      <Filter>resource</Filter>
+    </Image>
+  </ItemGroup>
+</Project>

builds/msvc/resource.rc

@@ -59,8 +59,8 @@ BOOL WINAPI executor::control_handler(DWORD signal)
 }
 
 // static
-LRESULT CALLBACK executor::window_proc(HWND handle, UINT message, WPARAM wparam,
-    LPARAM lparam)
+LRESULT CALLBACK executor::window_proc(HWND handle, UINT message,
+    WPARAM wparam, LPARAM lparam)
 {
     switch (message)
     {
@@ -69,7 +69,7 @@ LRESULT CALLBACK executor::window_proc(HWND handle, UINT message, WPARAM wparam,
         case WM_QUERYENDSESSION:
         {
             ::ShutdownBlockReasonCreate(handle, window_text);
-            stop(possible_narrow_sign_cast<int>(message));
+            executor::handle_stop(possible_narrow_sign_cast<int>(message));
             return FALSE;
         }
         default:
@@ -83,28 +83,32 @@ void executor::create_hidden_window()
 {
     thread_ = std::thread([this]()
     {
-        const WNDCLASSW window_class
+        const auto instance = ::GetModuleHandleW(NULL);
+        const WNDCLASSEXW window_class
         {
+            .cbSize = sizeof(WNDCLASSEXW),
+            .style = CS_HREDRAW | CS_VREDRAW,
             .lpfnWndProc = &executor::window_proc,
-            .hInstance = ::GetModuleHandleW(NULL),
-            .lpszClassName = window_name
+            .hInstance = instance,
+            .hIcon = ::LoadIconW(instance, MAKEINTRESOURCEW(101)),
+            .lpszClassName = window_name,
+            .hIconSm = ::LoadIconW(instance, MAKEINTRESOURCEW(101))
         };
 
         // fault
-        if (is_zero(::RegisterClassW(&window_class)))
+        if (is_zero(::RegisterClassExW(&window_class)))
             return;
 
-        // Window must be visible (?) to capture shutdown.
+        // Zero sizing results in title bar only.
+        // WS_EX_NOACTIVATE: prevents focus-stealing.
+        // WS_VISIBLE: required to capture WM_QUERYENDSESSION.
         window_ = ::CreateWindowExW
         (
-            0u,
+            WS_EX_NOACTIVATE,
             window_name,
             window_title,
             WS_VISIBLE,
-            CW_USEDEFAULT,
-            CW_USEDEFAULT,
-            400,
-            300,
+            0, 0, 0, 0,
             NULL,
             NULL,
             ::GetModuleHandleW(NULL),
@@ -139,10 +143,10 @@ void executor::destroy_hidden_window()
     if (!is_null(window_))
     {
         ::DestroyWindow(window_);
-        window_ = nullptr;
+        window_ = NULL;
     }
 
-    const HWND handle = ::GetConsoleWindow();
+    const auto handle = ::GetConsoleWindow();
     if (!is_null(handle))
         ::ShutdownBlockReasonDestroy(handle);
 }