results pages: parse and compute off the dispatcher with spinner, skip empty stats with a notice

Author: lepned

WebGUI/Components/Pages/ToolsFolder/BackendSpeed.razor

@@ -16,7 +16,7 @@
 	<div class="tool-subtitle">NPS and EPS by piece count from PGN games</div>
 
 	<div class="tool-controls">
-		<button class="tool-upload-btn" @onclick="BrowsePgnFile">Load pgn file</button>
+		<button class="tool-upload-btn" @onclick="BrowsePgnFile" disabled="@isProcessing">Load pgn file</button>
 		<div class="tool-input-group" style="margin-bottom:0">
 			<label>Engine filter</label>
 			<select class="tool-input" style="width:220px" @bind="selectedEngine" @bind:after="OnEngineChanged">
@@ -31,6 +31,19 @@
 
 	<div class="file-name">@fileOpenName</div>
 
+	@if (isProcessing)
+	{
+		<div class="file-name" style="display:flex; align-items:center; gap:10px;">
+			<MudProgressCircular Indeterminate="true" Size="Size.Small" />
+			<span>@processingStatus</span>
+		</div>
+	}
+
+	@if (!string.IsNullOrEmpty(noStatsMessage))
+	{
+		<div class="file-name" style="color:#d0a060;">@noStatsMessage</div>
+	}
+
 	<div class="tool-table-container" style="max-width:900px">
 		<table class="tool-table sortable">
 			<thead>
@@ -192,8 +205,13 @@
 		PGNStatistics.printPieceCountDataPerPgnFile(dummyOutputFilePath, pieceCountDataPerPgnFile);
 	}
 
+	private bool isProcessing;
+	private string processingStatus = "";
+	private string noStatsMessage = "";
+
 	private async Task BrowsePgnFile()
 	{
+		if (isProcessing) return;
 		var initialDir = SettingsService.Settings.PgnOutputFolder;
 		var parameters = new DialogParameters<WebGUI.Components.Layout.ExperimentalLayout.FileBrowserDialog>
 		{
@@ -211,28 +229,59 @@
 		fileOpenName = pgnName;
 		logger.LogInformation("PGN file opened {File}", pgnName);
 
-		List<ChessLibrary.PGNTypes.PgnGame> games;
+		isProcessing = true;
+		processingStatus = "Parsing PGN…";
+		noStatsMessage = "";
+		StateHasChanged();
 		try
 		{
-			games = FullPGNParser.parsePgnFile(filePath).ToList();
+			List<ChessLibrary.PGNTypes.PgnGame> games;
+			try
+			{
+				games = await Task.Run(() => FullPGNParser.parsePgnFile(filePath).ToList());
+			}
+			catch (Exception ex)
+			{
+				logger.LogError(ex, "Failed to parse PGN file {File}", pgnName);
+				return;
+			}
+			if (games.Count == 0)
+			{
+				logger.LogWarning("No games found in {File} — not a PGN file?", pgnName);
+				return;
+			}
+			logger.LogInformation("PGN file parsed {File}", pgnName);
+
+			processingStatus = $"Computing backend metrics for {games.Count:N0} games…";
+			StateHasChanged();
+			// keep the grouped data (F# shape) and notify UI; table reads FlattenedRows
+			pieceCountDataPerPgnFile = await Task.Run(() => PGNStatistics.calculatePieceCountDataPerPgnFile(games));
+			logger.LogInformation("Groups: {Count}", pieceCountDataPerPgnFile.Length);
+			if (pieceCountDataPerPgnFile.Length == 0)
+			{
+				// pcs= is only written with MoveAnnotation=Full, and only engines that
+				// report EPS (Ceres with LogLiveStats) produce nonzero eps= values
+				noStatsMessage = "No piece-count/EPS data found in this PGN — backend metrics needs a tournament played with MoveAnnotation=Full and an engine reporting EPS (e.g. Ceres).";
+				logger.LogWarning("No piece-count/EPS data in {File} — requires MoveAnnotation=Full and EPS-reporting engines", pgnName);
+				currentPage = 0;
+				return;
+			}
+			currentPage = 0;
+			StateHasChanged();
+
+			// attempt to plot automatically after load (filtered by current selection)
+			await PlotPieceCountChart();
 		}
 		catch (Exception ex)
 		{
-			logger.LogError(ex, "Failed to parse PGN file {File}", pgnName);
-			return;
+			logger.LogError(ex, "Backend metrics calculation failed for {File}", pgnName);
+		}
+		finally
+		{
+			isProcessing = false;
+			processingStatus = "";
+			StateHasChanged();
 		}
-		logger.LogInformation("PGN file parsed {File}", pgnName);
-
-		// keep the grouped data (F# shape) and notify UI; table reads FlattenedRows
-		pieceCountDataPerPgnFile = PGNStatistics.calculatePieceCountDataPerPgnFile(games);
-		logger.LogInformation("Groups: {Count}", pieceCountDataPerPgnFile.Length);
-		currentPage = 0;
-		StateHasChanged();
-
-		// attempt to plot automatically after load (filtered by current selection)
-		await PlotPieceCountChart();
-
-		StateHasChanged();
 	}
 
 

WebGUI/Components/Pages/ToolsFolder/DeviationFinder.razor

@@ -18,7 +18,7 @@
   <div class="tool-subtitle">Find and visualize move deviations across PGN games</div>
 
   <div class="tool-controls">
-    <button class="tool-upload-btn" @onclick="BrowsePgnFile">Load PGN file</button>
+    <button class="tool-upload-btn" @onclick="BrowsePgnFile" disabled="@isProcessing">Load PGN file</button>
     <div class="tool-input-group" style="margin-bottom:0; min-width:220px;">
       <label>Reference player name</label>
       <input type="text" class="tool-input" style="width:100%" @bind="refPlayer" />
@@ -39,6 +39,14 @@
 
   <div class="file-name">@fileName</div>
 
+  @if (isProcessing)
+  {
+    <div class="file-name" style="display:flex; align-items:center; gap:10px;">
+      <MudProgressCircular Indeterminate="true" Size="Size.Small" />
+      <span>@processingStatus</span>
+    </div>
+  }
+
   @if (!string.IsNullOrEmpty(resultDescription1))
   {
     <h2>@(isFindMoveAllDifferencesEnabled ? "Critical Move Differences Between Engines" : "Move Deviations By Same Engine")</h2>
@@ -257,8 +265,12 @@
     return deviatorColor == "w" ? res : -res;
   }
 
+  private bool isProcessing;
+  private string processingStatus = "";
+
   private async Task BrowsePgnFile()
   {
+    if (isProcessing) return;
     var initialDir = SettingsService.Settings.PgnOutputFolder;
     var parameters = new DialogParameters<WebGUI.Components.Layout.ExperimentalLayout.FileBrowserDialog>
     {
@@ -280,48 +292,78 @@
     resultDescription1 = "";
     resultDescription2 = "";
 
-    List<ChessLibrary.PGNTypes.PgnGame> games;
+    isProcessing = true;
+    processingStatus = "Parsing PGN…";
+    StateHasChanged();
     try
     {
-        games = FullPGNParser.parsePgnFile(filePath).ToList();
-    }
-    catch (Exception ex)
-    {
+      List<ChessLibrary.PGNTypes.PgnGame> games;
+      try
+      {
+        games = await Task.Run(() => FullPGNParser.parsePgnFile(filePath).ToList());
+      }
+      catch (Exception ex)
+      {
         logger.LogError(ex, "Failed to parse PGN file {File}", pgnName);
         return;
+      }
+      if (games.Count == 0)
+      {
+        logger.LogWarning("No games found in {File} — not a PGN file?", pgnName);
+        return;
+      }
+
+      processingStatus = $"Analyzing move deviations in {games.Count:N0} games…";
+      StateHasChanged();
+      var comparList = ConvertCsvStringToList(comparePlayers);
+      // Deviation analysis compares games pairwise — quadratic-ish work that must not
+      // run on the dispatcher. Materialize the lazy sequences once inside the task
+      // instead of re-running the whole analysis on every LINQ enumeration below.
+      var (deviations, critical, desc1, desc2) = await Task.Run(() =>
+      {
+        var devs =
+          (isFindMoveAllDifferencesEnabled ?
+            DeviationAnalysis.findMoveDifferencesInPGN(games, refPlayer, comparList) :
+            DeviationAnalysis.findAllDeviationsForAllPlayers(games))
+          .ToList();
+        var crit = devs.Where(e => e.Result != e.DevRes).ToList();
+
+        var sb = new StringBuilder();
+        foreach (var deviator in crit.Select(e => e.PlayerToDeviate).Distinct())
+        {
+          var playerDeviations = crit.Where(e => e.PlayerToDeviate == deviator).ToList();
+          var playerScore = playerDeviations.Sum(e => GetScore(e));
+          sb.AppendLine($"Player: {deviator} did deviate {playerDeviations.Count} times and resulted in a calculated net score of: {playerScore}");
+        }
+        var sb1 = new StringBuilder();
+        foreach (var deviator in devs.Select(e => e.PlayerToDeviate).Distinct())
+        {
+          var playerDeviations = devs.Where(e => e.PlayerToDeviate == deviator).ToList();
+          var playerScore = playerDeviations.Sum(e => GetScore(e));
+          sb1.AppendLine($"Player: {deviator} did deviate {playerDeviations.Count} times and resulted in a calculated net score of: {playerScore}");
+        }
+        return (devs, crit, sb.ToString(), sb1.ToString());
+      });
+
+      deviationListAll.AddRange(deviations);
+      deviationListCritical.AddRange(critical);
+      resultDescription1 = desc1;
+      resultDescription2 = desc2;
+      logger.LogInformation(resultDescription1);
+      logger.LogInformation(resultDescription2);
+      logger.LogInformation("Done with calculation");
+      currentPage = 0;
     }
-    var comparList = ConvertCsvStringToList(comparePlayers);
-    var deviations =
-      isFindMoveAllDifferencesEnabled ?
-        DeviationAnalysis.findMoveDifferencesInPGN(games, refPlayer, comparList) :
-        DeviationAnalysis.findAllDeviationsForAllPlayers(games);
-
-    deviationListAll.AddRange(deviations);
-    var critical = deviations.Where(e => e.Result != e.DevRes);
-    deviationListCritical.AddRange(critical);
-
-    var distinctCritical = critical.Select(e => e.PlayerToDeviate).Distinct();
-    var distinctAll = deviations.Select(e => e.PlayerToDeviate).Distinct();
-    var sb = new StringBuilder();
-    foreach (var deviator in distinctCritical)
+    catch (Exception ex)
     {
-      var playerDeviations = critical.Where(e => e.PlayerToDeviate == deviator);
-      var playerScore = playerDeviations.Sum(e => GetScore(e));
-      sb.AppendLine($"Player: {deviator} did deviate {playerDeviations.Count()} times and resulted in a calculated net score of: {playerScore}");
+      logger.LogError(ex, "Deviation analysis failed for {File}", pgnName);
     }
-    resultDescription1 = sb.ToString();
-    var sb1 = new StringBuilder();
-    foreach (var deviator in distinctAll)
+    finally
     {
-      var playerDeviations = deviations.Where(e => e.PlayerToDeviate == deviator);
-      var playerScore = playerDeviations.Sum(e => GetScore(e));
-      sb1.AppendLine($"Player: {deviator} did deviate {playerDeviations.Count()} times and resulted in a calculated net score of: {playerScore}");
+      isProcessing = false;
+      processingStatus = "";
+      StateHasChanged();
     }
-    resultDescription2 = sb1.ToString();
-    logger.LogInformation(resultDescription1);
-    logger.LogInformation(resultDescription2);
-    logger.LogInformation("Done with calculation");
-    currentPage = 0;
   }