Clifm doesn't compiles on Illumos

[extrowerk]

Describe the bug
White there is the misc/solaris folder, the Makefile in it doesn't really works on recent Illumos

To Reproduce
This is git master:

szilard@build:~/projekt/clifm/misc/solaris$ make
make: Fatal error in reader: Makefile, line 5: Badly formed macro assignment
szilard@build:~/projekt/clifm/misc/solaris$ gmake
gmake: *** No rule to make target 'src/*.c', needed by 'clifm'.  Stop.
szilard@build:~/projekt/clifm/misc/solaris$ uname -a
SunOS build 5.11 omnios-r151056-128de81dcd i86pc i386 i86pc
szilard@build:~/projekt/clifm/misc/solaris$

Expected behavior
Working build

[extrowerk]

cmake alos doesn't works:

szilard@build:~/projekt/clifm$ mkdir b
szilard@build:~/projekt/clifm$ cd b
szilard@build:~/projekt/clifm/b$ cmake ..
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


-- The C compiler identification is GNU 14.3.0
-- The CXX compiler identification is GNU 14.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done (0.8s)
-- Generating done (0.0s)
-- Build files have been written to: /export/home/szilard/projekt/clifm/b
szilard@build:~/projekt/clifm/b$ gmake
[  1%] Building C object CMakeFiles/clifm.dir/src/actions.c.o
[  3%] Building C object CMakeFiles/clifm.dir/src/archives.c.o
[  5%] Building C object CMakeFiles/clifm.dir/src/args.c.o
[  7%] Building C object CMakeFiles/clifm.dir/src/autocmds.c.o
[  9%] Building C object CMakeFiles/clifm.dir/src/aux.c.o
[ 11%] Building C object CMakeFiles/clifm.dir/src/bookmarks.c.o
[ 12%] Building C object CMakeFiles/clifm.dir/src/bulk_remove.c.o
[ 14%] Building C object CMakeFiles/clifm.dir/src/bulk_rename.c.o
[ 16%] Building C object CMakeFiles/clifm.dir/src/checks.c.o
[ 18%] Building C object CMakeFiles/clifm.dir/src/colors.c.o
[ 20%] Building C object CMakeFiles/clifm.dir/src/compat.c.o
[ 22%] Building C object CMakeFiles/clifm.dir/src/config.c.o
[ 24%] Building C object CMakeFiles/clifm.dir/src/dothidden.c.o
[ 25%] Building C object CMakeFiles/clifm.dir/src/exec.c.o
[ 27%] Building C object CMakeFiles/clifm.dir/src/file_operations.c.o
[ 29%] Building C object CMakeFiles/clifm.dir/src/fsinfo.c.o
[ 31%] Building C object CMakeFiles/clifm.dir/src/fuzzy_match.c.o
[ 33%] Building C object CMakeFiles/clifm.dir/src/help.c.o
[ 35%] Building C object CMakeFiles/clifm.dir/src/highlight.c.o
[ 37%] Building C object CMakeFiles/clifm.dir/src/history.c.o
[ 38%] Building C object CMakeFiles/clifm.dir/src/init.c.o
[ 40%] Building C object CMakeFiles/clifm.dir/src/jump.c.o
[ 42%] Building C object CMakeFiles/clifm.dir/src/keybinds.c.o
[ 44%] Building C object CMakeFiles/clifm.dir/src/listing.c.o
[ 46%] Building C object CMakeFiles/clifm.dir/src/long_view.c.o
[ 48%] Building C object CMakeFiles/clifm.dir/src/main.c.o
[ 50%] Building C object CMakeFiles/clifm.dir/src/media.c.o
[ 51%] Building C object CMakeFiles/clifm.dir/src/mem.c.o
[ 53%] Building C object CMakeFiles/clifm.dir/src/mime.c.o
[ 55%] Building C object CMakeFiles/clifm.dir/src/mimetypes.c.o
[ 57%] Building C object CMakeFiles/clifm.dir/src/misc.c.o
[ 59%] Building C object CMakeFiles/clifm.dir/src/name_cleaner.c.o
[ 61%] Building C object CMakeFiles/clifm.dir/src/navigation.c.o
[ 62%] Building C object CMakeFiles/clifm.dir/src/profiles.c.o
[ 64%] Building C object CMakeFiles/clifm.dir/src/prompt.c.o
[ 66%] Building C object CMakeFiles/clifm.dir/src/properties.c.o
[ 68%] Building C object CMakeFiles/clifm.dir/src/readline.c.o
[ 70%] Building C object CMakeFiles/clifm.dir/src/remotes.c.o
[ 72%] Building C object CMakeFiles/clifm.dir/src/sanitize.c.o
[ 74%] Building C object CMakeFiles/clifm.dir/src/search.c.o
[ 75%] Building C object CMakeFiles/clifm.dir/src/selection.c.o
[ 77%] Building C object CMakeFiles/clifm.dir/src/sort.c.o
[ 79%] Building C object CMakeFiles/clifm.dir/src/spawn.c.o
[ 81%] Building C object CMakeFiles/clifm.dir/src/strings.c.o
[ 83%] Building C object CMakeFiles/clifm.dir/src/suggestions.c.o
[ 85%] Building C object CMakeFiles/clifm.dir/src/tabcomp.c.o
[ 87%] Building C object CMakeFiles/clifm.dir/src/tags.c.o
[ 88%] Building C object CMakeFiles/clifm.dir/src/term.c.o
[ 90%] Building C object CMakeFiles/clifm.dir/src/translate_key.c.o
[ 92%] Building C object CMakeFiles/clifm.dir/src/trash.c.o
[ 94%] Building C object CMakeFiles/clifm.dir/src/view.c.o
[ 96%] Building C object CMakeFiles/clifm.dir/src/workspaces.c.o
[ 98%] Building C object CMakeFiles/clifm.dir/src/xdu.c.o
[100%] Linking C executable clifm
ld: fatal: library -lacl: not found
ld: fatal: library -lcap: not found
ld: fatal: file processing errors. No output written to clifm
collect2: error: ld returned 1 exit status
gmake[2]: *** [CMakeFiles/clifm.dir/build.make:932: clifm] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:87: CMakeFiles/clifm.dir/all] Error 2
gmake: *** [Makefile:136: all] Error 2
szilard@build:~/projekt/clifm/b$

The correct linker flags for Illumos are:

readline ncurses intl nvpair magic

Se here:
omniosorg/omnios-extra#1679

[leo-arch]

Hi @extrowerk. Try following these instructions.

As far as I can see (I don't have a Solaris box right now), the problem is that you're compiling from misc/solaris, when you should do it from the repo root dir instead. This is why gmake cannot locate src/*.c.

You can also modify SRCDIR in misc/solaris/Makefile to make it point to the correct location:

SRCDIR = ../../src

Then you can run gmake from misc/solaris.

[leo-arch]

The correct linker flags for Illumos are: readline ncurses intl nvpair magic

Thanks. And thank you very much for the Omnios recipe as well!

[extrowerk]

In the top level of the git master:

szilard@build:~/projekt/clifm$ gmake clean
rm -f -- clifm
rm -f -f -- src/*.o
szilard@build:~/projekt/clifm$ gmake
Detected operating system: SunOS
gcc -o clifm src/*.c -DCLIFM_DATADIR=/usr/local/share -O3 -fstack-protector-strong -Wall -Wextra
Undefined                       first referenced
 symbol                             in file
rl_filename_quoting_function        /var/tmp//ccQwaOMw.o
rl_bind_key                         /var/tmp//ccCwaOMw.o
rl_directory_completion_hook        /var/tmp//ccZwaOMw.o
rl_copy_text                        /var/tmp//ccywaOMw.o
nvlist_lookup_uint64_array          /var/tmp//cckwaOMw.o
rl_reset_line_state                 /var/tmp//ccCwaOMw.o
history_comment_char                /var/tmp//cczwaOMw.o
rl_get_keymap_by_name               /var/tmp//ccCwaOMw.o
rl_editing_mode                     /var/tmp//ccrwaOMw.o
rl_funmap_names                     /var/tmp//ccCwaOMw.o
rl_end_undo_group                   /var/tmp//ccCwaOMw.o
rl_bind_keyseq_in_map               /var/tmp//ccCwaOMw.o
rl_clear_visible_line               /var/tmp//cc4waOMw.o
rl_clear_pending_input              /var/tmp//ccKwaOMw.o
rl_filename_dequoting_function      /var/tmp//ccQwaOMw.o
history_expansion_char              /var/tmp//ccOwaOMw.o
rl_abort                            /var/tmp//ccZwaOMw.o
rl_point                            /var/tmp//cckwaOMw.o
rl_readline_state                   /var/tmp//ccQwaOMw.o
tilde_expand                        /var/tmp//cchwaOMw.o
rl_attempted_completion_function    /var/tmp//cctwaOMw.o
rl_library_version                  /var/tmp//ccpwaOMw.o
rl_free_undo_list                   /var/tmp//ccKwaOMw.o
rl_named_function                   /var/tmp//ccCwaOMw.o
rl_save_prompt                      /var/tmp//ccYwaOMw.o
rl_attempted_completion_over        /var/tmp//ccQwaOMw.o
rl_begin_undo_group                 /var/tmp//ccCwaOMw.o
rl_emacs_editing_mode               /var/tmp//ccrwaOMw.o
clear_history                       /var/tmp//cczwaOMw.o
rl_clear_history                    /var/tmp//ccKwaOMw.o
history_expand                      /var/tmp//ccOwaOMw.o
rl_callback_read_char               /var/tmp//ccQwaOMw.o
rl_stuff_char                       /var/tmp//ccCwaOMw.o
rl_delete                           /var/tmp//ccQwaOMw.o
rl_char_is_quoted_p                 /var/tmp//ccQwaOMw.o
emacs_standard_keymap               /var/tmp//ccCwaOMw.o
vi_insertion_keymap                 /var/tmp//ccCwaOMw.o
rl_prompt                           /var/tmp//ccCwaOMw.o
rl_kill_text                        /var/tmp//ccCwaOMw.o
rl_rubout                           /var/tmp//ccQwaOMw.o
rl_filename_completion_desired      /var/tmp//ccQwaOMw.o
rl_vi_editing_mode                  /var/tmp//ccrwaOMw.o
rl_sort_completion_matches          /var/tmp//ccQwaOMw.o
rl_getc_function                    /var/tmp//ccQwaOMw.o
rl_end                              /var/tmp//cckwaOMw.o
rl_line_buffer                      /var/tmp//cckwaOMw.o
rl_completer_word_break_characters  /var/tmp//ccQwaOMw.o
rl_extend_line_buffer               /var/tmp//ccQwaOMw.o
rl_bind_keyseq                      /var/tmp//ccCwaOMw.o
rl_special_prefixes                 /var/tmp//ccZwaOMw.o
rl_completer_quote_characters       /var/tmp//ccQwaOMw.o
rl_readline_version                 /var/tmp//ccpwaOMw.o
rl_callback_handler_remove          /var/tmp//ccQwaOMw.o
rl_delete_text                      /var/tmp//ccywaOMw.o
rl_crlf                             /var/tmp//ccZwaOMw.o
rl_ding                             /var/tmp//ccZwaOMw.o
rl_mark                             /var/tmp//cckwaOMw.o
magic_close                         /var/tmp//ccIwaOMw.o
history_write_timestamps            /var/tmp//ccAwaOMw.o
rl_clear_message                    /var/tmp//ccYwaOMw.o
rl_ignore_some_completions_function /var/tmp//ccZwaOMw.o
append_history                      /var/tmp//cczwaOMw.o
rl_completion_matches               /var/tmp//ccQwaOMw.o
read_history                        /var/tmp//cczwaOMw.o
rl_callback_handler_install         /var/tmp//ccQwaOMw.o
rl_restore_prompt                   /var/tmp//ccYwaOMw.o
rl_deactivate_mark                  /var/tmp//cckwaOMw.o
nvlist_free                         /var/tmp//cckwaOMw.o
rl_dispatching                      /var/tmp//cctwaOMw.o
rl_prep_terminal                    /var/tmp//ccCwaOMw.o
rl_completion_query_items           /var/tmp//ccZwaOMw.o
readline                            /var/tmp//ccOwaOMw.o
history_truncate_file               /var/tmp//cczwaOMw.o
rl_read_init_file                   /var/tmp//ccQwaOMw.o
rl_insert_text                      /var/tmp//ccywaOMw.o
rl_readline_name                    /var/tmp//ccQwaOMw.o
rl_outstream                        /var/tmp//ccZwaOMw.o
rl_filename_quote_characters        /var/tmp//ccQwaOMw.o
rl_deprep_terminal                  /var/tmp//ccCwaOMw.o
rl_invoking_keyseqs                 /var/tmp//ccCwaOMw.o
rl_activate_mark                    /var/tmp//cckwaOMw.o
rl_ignore_completion_duplicates     /var/tmp//ccQwaOMw.o
rl_get_keymap                       /var/tmp//ccCwaOMw.o
rl_set_keymap                       /var/tmp//ccCwaOMw.o
rl_forward_word                     /var/tmp//ccCwaOMw.o
rl_redisplay                        /var/tmp//cckwaOMw.o
rl_on_new_line                      /var/tmp//ccCwaOMw.o
rl_replace_line                     /var/tmp//ccCwaOMw.o
rl_completion_entry_function        /var/tmp//ccQwaOMw.o
rl_set_prompt                       /var/tmp//ccOwaOMw.o
add_history                         /var/tmp//cczwaOMw.o
rl_filename_quoting_desired         /var/tmp//ccZwaOMw.o
magic_file                          /var/tmp//ccIwaOMw.o
magic_load                          /var/tmp//ccIwaOMw.o
magic_open                          /var/tmp//ccIwaOMw.o
ld: fatal: symbol referencing errors. No output written to clifm
collect2: error: ld returned 1 exit status
gmake: *** [Makefile:39: clifm] Error 1
szilard@build:~/projekt/clifm$

[leo-arch]

Try this:

git clone https://github.com/leo-arch/clifm.git
cd clifm
gmake -f misc/solaris/Makefile

Make sure to install deps before: readline and magic.

[extrowerk]

This works!

szilard@build:~/projekt/clifm$ gmake -f misc/solaris/Makefile
gcc -o clifm src/*.c -DCLIFM_DATADIR=/usr/share -DSUN_VERSION=511 -O3 -fstack-protector-strong -Wall -Wextra  -lreadline -ltermcap -lmagic -lnvpair
szilard@build:~/projekt/clifm$ 

[leo-arch]

Great!

[extrowerk]

OmniOS recipe have been updated: omniosorg/omnios-extra#1679

[leo-arch]

Awesome. Thanks @extrowerk!