Commit ef256e2
feat(java): expose MemWAL shard delete (#7688)
## What
Mirrors the Python `ShardWriter.delete` binding on the Java side,
bringing the Java MemWAL bindings to parity with Python. The Rust core
`ShardWriter::delete` and the Python binding already exist; this wires
up the Java surface.
- **`java/lance-jni/src/mem_wal.rs`** — `nativeDelete` JNI entry point
(`inner_delete`) that streams Arrow key batches into
`ShardWriter::delete`, mirroring `nativePut`/`inner_put`.
- **`ShardWriter.java`** — public `delete(ArrowReader)` wrapper
mirroring `put`, with Javadoc copied from the Rust core (tombstone
semantics, nullable-column and primary-key constraints).
- **`MemWalTest.java`** — integration test
`testShardWriterDeleteMasksBaseRow` asserting a tombstone masks the
deleted base row, mirroring the Python
`test_shard_writer_delete_binding_masks_base_row`.
All validation and tombstone construction stay centralized in the Rust
core — the binding is a thin wrapper, per the cross-language binding
guidelines.
## Testing
- `cargo clippy --tests --manifest-path ./lance-jni/Cargo.toml` — clean
- `./mvnw spotless:check` + `cargo fmt` — clean
- `./mvnw test -Dtest=MemWalTest#testShardWriterDeleteMasksBaseRow` —
`Tests run: 1, Failures: 0`
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Added support for deleting records through the shard writer API.
* Deletions now work using primary-key-only input and are reflected as
hidden tombstone rows.
* **Bug Fixes**
* Deleted rows are now masked from query results while preserving other
existing records and newly added data.
* Added validation and safer handling for empty delete inputs and
invalid usage.
* **Tests**
* Added an integration test covering delete behavior and tombstone
masking.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent af8a90f commit ef256e2
3 files changed
Lines changed: 114 additions & 0 deletions
File tree
- java
- lance-jni/src
- src
- main/java/org/lance/memwal
- test/java/org/lance/memwal
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
184 | 207 | | |
185 | 208 | | |
186 | 209 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
39 | 40 | | |
40 | 41 | | |
41 | 42 | | |
| |||
99 | 100 | | |
100 | 101 | | |
101 | 102 | | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
102 | 131 | | |
103 | 132 | | |
104 | 133 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
100 | 116 | | |
101 | 117 | | |
102 | 118 | | |
| |||
382 | 398 | | |
383 | 399 | | |
384 | 400 | | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
385 | 447 | | |
386 | 448 | | |
387 | 449 | | |
| |||
0 commit comments