get_png_imageinfo.php compare on PNG signature fails

[kickofitall]

Thanks for this amazing piece of code!

It helped me a lot with my current project - with a small modification:

$info = unpack('a8sig/Nchunksize/A4chunktype/Nwidth/Nheight/Cbit-depth/'.
        'Ccolor/Ccompression/Cfilter/Cinterface', 
        file_get_contents($file,0,null,0,29))
        ;

With "A8sig" the last "0A" is droped and the PNG signature comparison fails.
With "a8sig" it worked for me.

Just to be mentioned...

(PHP 5.5.9, Win7x64)

[FionNoir]

Hey, thanks a lot! Your fix works perfect for me!

[ktomk]

It would be great to have a demonstration picture so that I can do some regression testing.

[FionNoir]

Hello Tom, attached you will find a file I’ve used to test your code. It’s a PNG 32-Bit from my client. So please use it only for testing purpose. I do not understand what’s going on here: $info = unpack('a8sig/Nchunksize/A4chunktype/Nwidth/Nheight/Cbit-depth/'. 'Ccolor/Ccompression/Cfilter/Cinterface', file_get_contents($file,0,null,0,29)); But changing A8sig to a8sig worked with this file and all others I‘ve tested so far.

[ktomk]

@FionNoir: I think you have to add it to the Github issue, as Github won't extract the attachment from your reply.

[FionNoir]

@ktomk Then would you please provide me an other email adress because ist not a good idea to publish images of my clients which I do not have the copyright for. Or is there a way to make it only visible for you?