Performance suite compilation errors

[AChisolmAMD]

I ran into some compilation errors when trying to compile the performance tests with HIP.

Here's my build command:
cmake -B build -DCMAKE_CXX_COMPILER=hipcc -DCMAKE_C_COMPILER=gcc -DKokkosKernels_ENABLE_TESTS_AND_PERFSUITE=ON -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH=~/kokkos/build && cmake --build build

Here are the errors:

...
[ 67%] Building CXX object perf_test/CMakeFiles/tracked_testing.dir/KokkosKernelsTrackedTesting.cpp.o
In file included from /home/andrew/kokkos-kernels/perf_test/KokkosKernelsTrackedTesting.cpp:21:
In file included from /home/andrew/kokkos-kernels/perf_test/sparse/tracked_testing.hpp:23:
In file included from /home/andrew/kokkos-kernels/perf_test/sparse/KokkosSparse_spmv_test.hpp:34:
/home/andrew/kokkos-kernels/perf_test/PerfTestUtilities.hpp:84:33: error: no member named 'read_kokkos_crst_matrix' in namespace 'KokkosKernels::Impl'
   84 |     return KokkosKernels::Impl::read_kokkos_crst_matrix<matrix_type<Scalar, Ordinal, ExecutionSpace, Offset>>(
      |            ~~~~~~~~~~~~~~~~~~~~~^
/home/andrew/kokkos-kernels/perf_test/PerfTestUtilities.hpp:84:109: error: expected '(' for function-style cast or type construction
   84 |     return KokkosKernels::Impl::read_kokkos_crst_matrix<matrix_type<Scalar, Ordinal, ExecutionSpace, Offset>>(
      |                                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
In file included from /home/andrew/kokkos-kernels/perf_test/KokkosKernelsTrackedTesting.cpp:26:
In file included from /home/andrew/kokkos-kernels/perf_test/blas/blas2/tracked_testing.hpp:25:
/home/andrew/kokkos-kernels/perf_test/blas/blas2/KokkosBlas2_gemv_perf_test.hpp:23:10: fatal error: 'blas/KokkosBlas1_dot.hpp' file not found
   23 | #include "blas/KokkosBlas1_dot.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated when compiling for gfx1100.

I believe these errors are due to organizational changes that didn't fully propagate. At some point the read_kokkos_crst_matrix function was moved from the KokkosKernels namespace to the KokkosSparse namespace, but this code wasn't updated.

[lucbv]

Thanks for reporting this issue, I am looking at refactoring significantly how our performance tests and benchmarks are being built and tested. Do you need a quick resolution on this or are you fine ignoring this for the time being?

[AChisolmAMD]

Thanks, I'm OK to wait.