Add unpause to any error cases in KPA reconcile

Author: Alexander-Kita

pkg/reconciler/autoscaling/kpa/kpa.go

@@ -101,6 +101,7 @@ func (c *Reconciler) ReconcileKind(ctx context.Context, pa *autoscalingv1alpha1.
 		// Before we can reconcile decider and get real number of activators
 		// we start with default of 2.
 		if _, err = c.ReconcileSKS(ctx, pa, nv1alpha1.SKSOperationModeProxy, minActivators); err != nil {
+			pa.Status.MetricsPaused = false
 			return fmt.Errorf("error reconciling SKS: %w", err)
 		}
 		pa.Status.MarkSKSNotReady(noPrivateServiceName) // In both cases this is true.
@@ -118,13 +119,15 @@ func (c *Reconciler) ReconcileKind(ctx context.Context, pa *autoscalingv1alpha1.
 	}
 
 	if err := c.ReconcileMetric(ctx, pa, resolveScrapeTarget(ctx, pa)); err != nil {
+		pa.Status.MetricsPaused = false
 		return fmt.Errorf("error reconciling Metric: %w", err)
 	}
 
 	// Get the appropriate current scale from the metric, and right size
 	// the scaleTargetRef based on it.
 	want, err := c.scaler.scale(ctx, pa, sks, decider.Status.DesiredScale)
 	if err != nil {
+		pa.Status.MetricsPaused = false
 		return fmt.Errorf("error scaling target: %w", err)
 	}
 
@@ -148,6 +151,7 @@ func (c *Reconciler) ReconcileKind(ctx context.Context, pa *autoscalingv1alpha1.
 	podCounter := resourceutil.NewPodAccessor(c.podsLister, pa.Namespace, pa.Labels[serving.RevisionLabelKey])
 	ready, notReady, pending, terminating, err := podCounter.PodCountsByState()
 	if err != nil {
+		pa.Status.MetricsPaused = false
 		return fmt.Errorf("error getting pod counts: %w", err)
 	}
 
@@ -160,6 +164,7 @@ func (c *Reconciler) ReconcileKind(ctx context.Context, pa *autoscalingv1alpha1.
 
 	sks, err = c.ReconcileSKS(ctx, pa, mode, numActivators)
 	if err != nil {
+		pa.Status.MetricsPaused = false
 		return fmt.Errorf("error reconciling SKS: %w", err)
 	}
 	// Propagate service name.