Skip to content

Fold sampler.enabled into mode = "record" (deja recording config) #13435

Description

@maverox

Record mode is meaningless without the per-request sampler: a record-mode process with the sampler disabled should not be representable.

Collapse the two knobs so that mode = "record" implies the sampler, and drop (or derive) the separate [deja.sampler] enabled flag from the settings surface introduced by the recording-sink/boot PR. This is a pure config-surface simplification with no behavior change for a correctly-configured deployment — it just removes a footgun state (mode = "record" + sampler.enabled = false) that can only misconfigure a recording fleet.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-tracking-issueCategory: Tracking issue for a proposal or a category of bugs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions