Skip to content

Commit f57523f

Browse files
committed
fix: resolve CI matrix Node exclusions and npm ls failures
1 parent 17c3a54 commit f57523f

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/eslint-8-.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ jobs:
7474
name: 'nvm install ${{ matrix.node-version }} && npm install'
7575
with:
7676
node-version: ${{ matrix.node-version }}
77+
skip-ls-check: true
7778
after_install: |
7879
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.typescript-eslint == 8 && 8.17 || matrix.typescript-eslint }}" "babel-eslint@${{ matrix.babel-eslint }}" ${{ matrix.typescript-eslint >= 6 && '"typescript@5"' || '' }}
7980
env:

.github/workflows/eslint-9+.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,13 @@ jobs:
4141
exclude:
4242
# ESLint 10 supports Node.js ^20.19.0 || ^22.13.0 || >=24
4343
- eslint: 10
44-
node-version: "18"
44+
node-version: 18
4545
- eslint: 10
46-
node-version: "19"
46+
node-version: 19
4747
- eslint: 10
48-
node-version: "21"
48+
node-version: 21
4949
- eslint: 10
50-
node-version: "23"
50+
node-version: 23
5151
- eslint: 10
5252
babel-eslint: 8
5353

@@ -60,7 +60,6 @@ jobs:
6060
after_install: |
6161
npm remove --no-save eslint-doc-generator
6262
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.eslint == 10 && 'canary' || (matrix.typescript-eslint == 8 && 8.17 || matrix.typescript-eslint) }}" "babel-eslint@${{ matrix.babel-eslint }}" "typescript@5"
63-
skip-ls-check: true
6463
- run: npx ls-engines
6564
- run: npm run unit-test
6665
- uses: codecov/codecov-action@v3.1.5

.github/workflows/node-minors.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ jobs:
8080
node-version: ${{ matrix.node-version }}
8181
after_install: |
8282
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.node-version >= 18 && matrix.eslint >= 8 && '8.17' || (matrix.node-version >= 16 && matrix.eslint >= 7 && '6' || (matrix.node-version >= 14 && '5' || (matrix.node-version >= 12 && '4' || (matrix.node-version >= 10 && '4.0' || (matrix.node-version >= 8 && '3' || '2'))))) }}" "babel-eslint@${{ matrix.babel-eslint }}" ${{ matrix.node-version >= 16 && matrix.eslint >= 7 && '"typescript@5"' || '' }}
83-
skip-ls-check: ${{ matrix.node-version < 10 && true || false }}
83+
skip-ls-check: true
8484
env:
8585
NPM_CONFIG_LEGACY_PEER_DEPS: "${{ matrix.node-version >= 16 && matrix.eslint >= 7 && 'false' || 'true' }}"
8686
- run: npx ls-engines

0 commit comments

Comments
 (0)