Skip to content

Commit 079dadc

Browse files
committed
Revert "[Tests] always use legacy peer-deps on eslint-8- and node-minors matrices"
This reverts commit e47c827.
1 parent e47c827 commit 079dadc

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/eslint-8-.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ jobs:
9999
after_install: |
100100
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.typescript-eslint == 8 && 8.17 || matrix.typescript-eslint }}" "babel-eslint@${{ matrix.babel-eslint }}"
101101
env:
102-
NPM_CONFIG_LEGACY_PEER_DEPS: "true"
102+
NPM_CONFIG_LEGACY_PEER_DEPS: "${{ matrix.typescript-eslint >= 6 && 'false' || 'true' }}"
103103
- run: npx ls-engines
104104
- run: npm run unit-test
105105
- uses: codecov/codecov-action@v3.1.5

.github/workflows/node-minors.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ jobs:
103103
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.node-version >= 18 && matrix.eslint >= 8 && '8.17' || (matrix.node-version >= 16 && matrix.eslint >= 7 && '6' || (matrix.node-version >= 14 && '5' || (matrix.node-version >= 12 && '4' || (matrix.node-version >= 10 && '4.0' || (matrix.node-version >= 8 && '3' || '2'))))) }}" "babel-eslint@${{ matrix.babel-eslint }}"
104104
skip-ls-check: ${{ matrix.node-version < 10 && true || false }}
105105
env:
106-
NPM_CONFIG_LEGACY_PEER_DEPS: "true"
106+
NPM_CONFIG_LEGACY_PEER_DEPS: "${{ matrix.node-version >= 16 && matrix.eslint >= 7 && 'false' || 'true' }}"
107107
- run: npx ls-engines
108108
if: ${{ matrix.node-version >= 12 }}
109109
- run: npm run unit-test

0 commit comments

Comments
 (0)