perf(modeling): small performance changes to plane.from functions

Author: z3dev

packages/modeling/src/maths/plane/fromNormalAndPoint.js

@@ -18,7 +18,7 @@ import * as vec3 from '../vec3/index.js'
  * @alias module:modeling/maths/plane.fromNormalAndPoint
  */
 export const fromNormalAndPoint = (out, normal, point) => {
-  const u = vec3.normalize(vec3.create(), normal)
+  const u = vec3.normalize(out, normal)
   const w = vec3.dot(point, u)
 
   out[0] = u[0]

packages/modeling/src/maths/plane/fromPoints.js

@@ -26,14 +26,14 @@ export const fromPoints = (out, ...vertices) => {
     return ba
   }
 
-  out[0] = 0
-  out[1] = 0
-  out[2] = 0
   if (len === 3) {
     // optimization for triangles, which are always coplanar
     vec3.copy(out, vertexNormal(0))
   } else {
     // sum of vertex normals
+    out[0] = 0
+    out[1] = 0
+    out[2] = 0
     vertices.forEach((v, i) => {
       vec3.add(out, out, vertexNormal(i))
     })

packages/modeling/src/maths/plane/fromPointsRandom.js

@@ -18,23 +18,24 @@ export const fromPointsRandom = (out, a, b, c) => {
   let ba = vec3.subtract(vec3.create(), b, a)
   let ca = vec3.subtract(vec3.create(), c, a)
   if (vec3.length(ba) < EPS) {
-    ba = vec3.orthogonal(ba, ca)
+    vec3.orthogonal(ba, ca)
   }
   if (vec3.length(ca) < EPS) {
-    ca = vec3.orthogonal(ca, ba)
+    vec3.orthogonal(ca, ba)
   }
-  let normal = vec3.cross(vec3.create(), ba, ca)
+
+  // calculate plane normal
+  let normal = vec3.cross(out, ba, ca)
   if (vec3.length(normal) < EPS) {
     // this would mean that ba == ca.negated()
-    ca = vec3.orthogonal(ca, ba)
-    normal = vec3.cross(normal, ba, ca)
+    vec3.orthogonal(ca, ba)
+    vec3.cross(normal, ba, ca)
   }
-  normal = vec3.normalize(normal, normal)
-  const w = vec3.dot(normal, a)
+  vec3.normalize(normal, normal)
 
-  out[0] = normal[0]
-  out[1] = normal[1]
-  out[2] = normal[2]
+  // and distance
+  const w = vec3.dot(normal, a)
   out[3] = w
+
   return out
 }