Skip to content
This repository was archived by the owner on Apr 24, 2025. It is now read-only.

[BUG] Serverless deploy doesn't support parameters before "serverless", no explicit error/warnings about it #358

@ilovelinux

Description

@ilovelinux

I'm submitting a...

  • Bug report
  • Feature request
  • Documentation issue or request
  • Other... Please describe:

Code

const passingArguments = process.argv.slice(4).join(' ');
await execAsync('serverless deploy ' + passingArguments, { cwd: this.$cli.projectPath });

Expected Behavior

Running jovo deploy:code --stage prod serverless --debug should give an explicit error.
We could check if process.argv[3] == "serverless" and if it's not, raise the error.

Something like that:

$ jovo deploy:code --stage prod serverless --debug
Please run jovo deploy:code serverless <parameters>, we don't support parameters before "serverless"

Current Behavior

Running jovo deploy:code --stage prod serverless --debug will execute serverless deploy prod serverless --debug which is not a supported syntax by serverless.

Solutions

Error log

$ jovo deploy:code --stage prod serverless --debug
                                                                                
jovo deploy:code: Upload the source code to a cloud provider
  >> Learn more: https://jovo.tech/docs/deploy-command#deploy-code

                                                                                
✔ 📦 Bundling your code
✖ 🚀 Deploying to Serverless
                                                                                
x Error: --------------------------------------------------------------------------------
›                                                                                 
› Message:
›  Serverless deployment failed.
›                                                                                 
› Module:
›  ServerlessCli
›                                                                                 
›                                                                                 
› If you think this is not on you, you can submit an issue here: https://github.com/jovotech/jovo-cli/issues.

Your Environment

  • Jovo CLI version used: 4.1.9
  • Jovo Target-Serverless: 4.1.8
  • Operating System: Mac (sadly)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions