Larastan clean 3 (#37)

* Update UserActivityService.php - Parameter #2 $ttl of static method Illuminate\Support\Facades\Cache::remember() expects

* Update FeedService.php - Match expression does not handle remaining value: mixed

* Update AdminSetting.php - Expression on left side of ?? is not nullable.

* Update SettingsController.php - Ternary operator condition is always true.

Author: shleeable

app/Http/Controllers/Api/SettingsController.php

@@ -39,7 +39,7 @@ public function storeBio(UpdateProfileRequest $request)
         $originalData = $user->only(['name', 'bio']);
 
         if ($request->filled('name')) {
-            $name = $request->filled('name') ? $request->input('name') : AccountService::getDefaultDisplayName($user->profile_id);
+            $name = $request->input('name') ?: AccountService::getDefaultDisplayName($user->profile_id);
             $profile->name = $this->purify($name);
             $user->name = $this->purify($name);
             $user->save();

app/Models/AdminSetting.php

@@ -59,7 +59,7 @@ public static function set($key, $value, $type = 'object', $isPublic = false, $d
                 'is_public' => $isPublic,
                 'description' => $description,
                 'updated_by' => auth()->id(),
-                'version' => static::where('key', $key)->value('version') + 1 ?? 1,
+                'version' => (static::where('key', $key)->value('version') ?? 0) + 1,
             ]
         );
     }

app/Services/FeedService.php

@@ -16,7 +16,8 @@ public static function getAccountFeed($profileId, $limit, $sort)
                 match ($sort) {
                     'Latest' => $query->orderByDesc('id'),
                     'Popular' => $query->orderByDesc('likes'),
-                    'Oldest' => $query->orderBy('created_at')
+                    'Oldest' => $query->orderBy('created_at'),
+                    default => $query->orderByDesc('id')
                 };
             })
             ->cursorPaginate(10);

app/Services/UserActivityService.php

@@ -15,7 +15,7 @@ public function markActive(User $user, ?Carbon $ts = null): void
         $ymd = $ts->format('Ymd');
         $key = "ua:{$user->id}:{$ymd}";
 
-        $ttl = $ts->startOfDay()->addDay()->diffInSeconds($ts) + 5;
+        $ttl = (int) ($ts->startOfDay()->addDay()->diffInSeconds($ts) + 5);
 
         Cache::remember($key, $ttl, function () use ($ts, $user) {
             $user->forceFill(['last_active_at' => $ts])->saveQuietly();