Buffer overflow due to UB

[Jardynq]

In Interleaf::ReadChunk on line 145, 147 and 156 respectively, it casts an integer to a string. This works most of the time, but is UB. If the int doesn't contain a null byte, then it reads into junk data.

E.g. take line 145 as an example:

desc << ((const char *) &rand_val);

It seems unintended? Wouldn't the following be what is intended?

desc << rand_val;

Otherwise this does the same, just safer:

int len = strnlen((*const char)&rand_val, sizeof(rand_val));
desc << std::string(rand_val, len);

[itsmattkc]

The latter is the more correct solution, we are indeed reinterpreting these bytes as a string. I think the idea is that the strings we found were only ever 8 chars long so we figured they would fit into a 64-bit unsigned int.

That being said, it is a problem that this means they aren't null terminated in memory. I'm not sure how that slipped in. They are in fact null terminated in the file (with 9 chars), so it would actually make more sense to read char-by-char into a formal string. This should probably be corrected.

Arguably, now that we have a decompilation of LEGO Island, the SI parsing implementation could be replaced with the one from the game since it would be more accurate. Whether that's worth the time or not is another question.