-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Convert ReadingGoalProgress partial to Jinja #13567
Copy link
Copy link
Open
Labels
Good First IssueEasy issue. Good for newcomers. [managed]Easy issue. Good for newcomers. [managed]Lead: @RayBBIssues overseen by Ray (Onboarding & Documentation Lead) [manages]Issues overseen by Ray (Onboarding & Documentation Lead) [manages]Needs: HelpIssues, typically substantial ones, that need a dedicated developer to take them on. [managed]Issues, typically substantial ones, that need a dedicated developer to take them on. [managed]Needs: ResponseIssues which require feedback from leadIssues which require feedback from leadTheme: Reading LogRelated to workflows for creating, modifying, displaying a user's reading log. [managed]Related to workflows for creating, modifying, displaying a user's reading log. [managed]Type: Subtask of EpicA subtask that is part of the work breakdown of an epic issue (see comments). [managed]A subtask that is part of the work breakdown of an epic issue (see comments). [managed]
Description
Activity
Metadata
Metadata
Assignees
Labels
Good First IssueEasy issue. Good for newcomers. [managed]Easy issue. Good for newcomers. [managed]Lead: @RayBBIssues overseen by Ray (Onboarding & Documentation Lead) [manages]Issues overseen by Ray (Onboarding & Documentation Lead) [manages]Needs: HelpIssues, typically substantial ones, that need a dedicated developer to take them on. [managed]Issues, typically substantial ones, that need a dedicated developer to take them on. [managed]Needs: ResponseIssues which require feedback from leadIssues which require feedback from leadTheme: Reading LogRelated to workflows for creating, modifying, displaying a user's reading log. [managed]Related to workflows for creating, modifying, displaying a user's reading log. [managed]Type: Subtask of EpicA subtask that is part of the work breakdown of an epic issue (see comments). [managed]A subtask that is part of the work breakdown of an epic issue (see comments). [managed]
Part of #13566. See the epic for the full pattern, playbook, and test steps.
Convert 3 files:
openlibrary/templates/reading_goals/reading_goal_progress.html(29 lines),openlibrary/templates/reading_goals/reading_goal_form.html(24 lines),openlibrary/templates/native_dialog.html(15 lines). Render fromReadingGoalProgressPartialinopenlibrary/plugins/openlibrary/partials.py. Delete the old files. Switch the 2account/view.htmlcall sites of the form and dialog in the same PR (or bridge them — state your choice in the PR).Test
GET /partials/ReadingGoalProgress.jsonwhile logged in (dev useropenlibrary/openlibrary). Keep the parsed DOM identical. No new tests.