Skip to content

Convert ReadingGoalProgress partial to Jinja #13567

Description

@RayBB

This is a good first issue. Comment that you'd like to work on it — don't wait to be assigned — then open a PR referencing this issue. Anyone may open a PR, but please don't open one if another PR is already open for this issue.

Part of #13566. See the epic for the full pattern, playbook, and test steps.

Convert 3 files: openlibrary/templates/reading_goals/reading_goal_progress.html (29 lines), openlibrary/templates/reading_goals/reading_goal_form.html (24 lines), openlibrary/templates/native_dialog.html (15 lines). Render from ReadingGoalProgressPartial in openlibrary/plugins/openlibrary/partials.py. Delete the old files. Switch the 2 account/view.html call sites of the form and dialog in the same PR (or bridge them — state your choice in the PR).

Test GET /partials/ReadingGoalProgress.json while logged in (dev user openlibrary / openlibrary). Keep the parsed DOM identical. No new tests.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Good First IssueEasy issue. Good for newcomers. [managed]Lead: @RayBBIssues overseen by Ray (Onboarding & Documentation Lead) [manages]Needs: HelpIssues, typically substantial ones, that need a dedicated developer to take them on. [managed]Needs: ResponseIssues which require feedback from leadTheme: Reading LogRelated to workflows for creating, modifying, displaying a user's reading log. [managed]Type: Subtask of EpicA subtask that is part of the work breakdown of an epic issue (see comments). [managed]

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions