refactor: ♻️ use backend-provided resource specs instead of environment variables (#804)

- Remove QUERY_ALL_RESOURCE_SPECS workaround query that was finding
specs by name
- Simplify useResourceSpecs hook to only query QUERY_PROJECT_TYPES
- Update ProductsActiveFiltersBar and ProductsFilters to use specMachine
from hook
- Remove RESOURCE_SPEC_MACHINE and RESOURCE_SPEC_MATERIAL env variable
fallbacks
- Add skip condition to queries when spec IDs are not yet available

This completes the migration from env-based spec IDs to backend-provided
instanceVariables.specs which now exposes specMachine and specMaterial.

Closes interfacer-gui-9lv.17 (already closed)
Related to interfacer-gui-3hv (workaround removal)

Author: phoebus-84

components/ProductsActiveFiltersBar.tsx

@@ -16,8 +16,8 @@
 
 import { useQuery } from "@apollo/client";
 import { Tag } from "@bbtgnn/polaris-interfacer";
+import { useResourceSpecs } from "hooks/useResourceSpecs";
 import { QUERY_MACHINES } from "lib/QueryAndMutation";
-import { RESOURCE_SPEC_MACHINE } from "lib/resourceSpecs";
 import { isPrefixedTag, prefixedTag, TAG_PREFIX } from "lib/tagging";
 import { useTranslation } from "next-i18next";
 import { useRouter } from "next/router";
@@ -73,8 +73,12 @@ export default function ProductsActiveFiltersBar() {
   const { t } = useTranslation("productsProps");
   const router = useRouter();
 
+  // Get spec IDs from backend via hook
+  const { specMachine } = useResourceSpecs();
+
   const { data: machinesData } = useQuery<MachinesQueryData>(QUERY_MACHINES, {
-    variables: { resourceSpecId: RESOURCE_SPEC_MACHINE },
+    variables: { resourceSpecId: specMachine?.id || "" },
+    skip: !specMachine?.id,
   });
 
   const availableMachines = machinesData?.economicResources?.edges?.map(e => e.node) || [];

components/ProductsFilters.tsx

@@ -15,8 +15,9 @@
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 import { useQuery } from "@apollo/client";
+import { useResourceSpecs } from "hooks/useResourceSpecs";
 import { QUERY_MACHINES } from "lib/QueryAndMutation";
-import { MACHINE_TYPES, RESOURCE_SPEC_MACHINE } from "lib/resourceSpecs";
+import { MACHINE_TYPES } from "lib/resourceSpecs";
 import {
   CO2_THRESHOLDS_KG,
   ENERGY_THRESHOLDS_KWH,
@@ -97,11 +98,15 @@ export default function ProductsFilters() {
   const { t } = useTranslation("productsProps");
   const router = useRouter();
 
+  // Get spec IDs from backend via hook
+  const { specMachine } = useResourceSpecs();
+
   // Query available machines from backend
   const { data: machinesData, loading: machinesLoading } = useQuery<MachinesQueryData>(QUERY_MACHINES, {
     variables: {
-      resourceSpecId: RESOURCE_SPEC_MACHINE,
+      resourceSpecId: specMachine?.id || "",
     },
+    skip: !specMachine?.id,
   });
 
   // Get machines list from query or use fallback

hooks/useResourceSpecs.ts

@@ -15,57 +15,27 @@
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 import { useQuery } from "@apollo/client";
-import { QUERY_ALL_RESOURCE_SPECS, QUERY_PROJECT_TYPES } from "lib/QueryAndMutation";
+import { QUERY_PROJECT_TYPES } from "lib/QueryAndMutation";
 import { GetProjectTypesQuery } from "lib/types";
 
-interface ResourceSpec {
-  id: string;
-  name: string;
-}
-
-interface AllResourceSpecsQuery {
-  resourceSpecifications: {
-    edges: Array<{
-      node: ResourceSpec;
-    }>;
-  };
-}
-
 /**
  * Hook to get all ResourceSpecification IDs including DPP, Machine, Material
  *
- * WORKAROUND: The backend seeds specDpp, specMachine, specMaterial but doesn't
- * expose them via instanceVariables yet. This hook queries resourceSpecifications
- * directly and finds specs by name as a fallback.
- *
- * Once backend exposes these via instanceVariables, this hook can be simplified.
+ * Gets specs from backend instanceVariables which now exposes all required specs:
+ * specProjectDesign, specProjectProduct, specProjectService, specDpp, specMachine, specMaterial
  */
 export const useResourceSpecs = () => {
-  // Try to get specs from instanceVariables first
-  const { data: instanceData, loading: instanceLoading } = useQuery<GetProjectTypesQuery>(QUERY_PROJECT_TYPES);
-
-  // Fallback: query all resourceSpecifications and find by name
-  const { data: allSpecsData, loading: allSpecsLoading } = useQuery<AllResourceSpecsQuery>(QUERY_ALL_RESOURCE_SPECS);
-
-  const instanceSpecs = instanceData?.instanceVariables?.specs;
-  const allSpecs = allSpecsData?.resourceSpecifications?.edges?.map(e => e.node) || [];
-
-  // Helper to find spec by name from allSpecs
-  const findSpecByName = (name: string): ResourceSpec | undefined => {
-    return allSpecs.find(s => s.name.toLowerCase() === name.toLowerCase());
-  };
-
-  // Project types - try instanceVariables first, fallback to query by name
-  const specProjectDesign = instanceSpecs?.specProjectDesign || findSpecByName("Design");
-  const specProjectProduct = instanceSpecs?.specProjectProduct || findSpecByName("Product");
-  const specProjectService = instanceSpecs?.specProjectService || findSpecByName("Service");
+  const { data: instanceData, loading } = useQuery<GetProjectTypesQuery>(QUERY_PROJECT_TYPES);
 
-  // DPP, Machine, Material - try instanceVariables first, fallback to query by name
-  const specDpp = instanceSpecs?.specDpp || findSpecByName("DPP");
-  const specMachine = instanceSpecs?.specMachine || findSpecByName("Machine");
-  const specMaterial = instanceSpecs?.specMaterial || findSpecByName("Material");
+  const specs = instanceData?.instanceVariables?.specs;
 
-  const loading = instanceLoading || allSpecsLoading;
+  // Extract individual specs
+  const specProjectDesign = specs?.specProjectDesign;
+  const specProjectProduct = specs?.specProjectProduct;
+  const specProjectService = specs?.specProjectService;
+  const specDpp = specs?.specDpp;
+  const specMachine = specs?.specMachine;
+  const specMaterial = specs?.specMaterial;
 
   // Check if we have all required specs
   const hasProjectSpecs = !!(specProjectDesign && specProjectProduct && specProjectService);

lib/QueryAndMutation.ts

@@ -20,19 +20,6 @@ import { gql } from "@apollo/client";
  * Query to fetch all resource specifications
  * Used as fallback when instanceVariables doesn't expose specDpp, specMachine, specMaterial
  */
-export const QUERY_ALL_RESOURCE_SPECS = gql`
-  query GetAllResourceSpecs {
-    resourceSpecifications(first: 50) {
-      edges {
-        node {
-          id
-          name
-        }
-      }
-    }
-  }
-`;
-
 export const QUERY_VARIABLES = gql`
   query GetVariables {
     instanceVariables {