Support multi tenant secrets

[christianrolle]

This chapter https://github.com/integrallis/stripe_event#configuration reads like if there is a possibility to configure secrets in a multi tenant environment.
However

stripe_event/app/controllers/stripe_event/webhook_controller.rb

Line 33 in 9601d96

return StripeEvent.signing_secrets if StripeEvent.signing_secret

and

stripe_event/lib/stripe_event.rb

Line 8 in 9601d96

attr_reader :signing_secrets

pretty much look like a static interface for the secret configuration.

Is such an interface like:

class StripeTenantSigningSecret
  def call(params)
    StripeAccount.for_tenant(params[:tenant]).pluck :signing_secret
  end
end
StripeEvent.signing_secret = StripeTenantSigningSecret.new

a valid user story for the gem?
Otherwise I see no other chance than overwriting the

stripe_event/app/controllers/stripe_event/webhook_controller.rb

Line 32 in 9601d96

def secrets(payload, signature)

[julienbourdeau]

I'm considering using the gem so I haven't tested it myself yet but from what I understand it depends what we call "multi tenant environment".

In the gem, you'll need to set ALL the signing keys in the configuration

StripeEvent.signing_secrets = [
  ENV['STRIPE_LEGACY_ACCOUNT_SIGNING_SECRET'],
  ENV['STRIPE_ACCOUNT_2_SIGNING_SECRET'],
  ENV['STRIPE_ACCOUNT_3_SIGNING_SECRET'],
]

The gem will test all secrets when receiving a webhook.

stripe_event/app/controllers/stripe_event/webhook_controller.rb

Lines 22 to 29 in 9601d96

	possible_secrets.each_with_index do |secret, i|
	begin
	return Stripe::Webhook.construct_event(payload, signature, secret.to_s)
	rescue Stripe::SignatureVerificationError
	raise if i == possible_secrets.length - 1
	next
	end
	end

1️⃣ It's great if "multi tenant" means:

• I use Stripe Connect because I'm a marketplace (what the readme shows)
• We are one company but we have a few Stripe Accounts for Historical Reasons ™️

2️⃣ It's definitely not suitable if multi tenant means "I have thousands of users and they all use THEIR Stripe accounts". For performance for sure but it could even be a security issue 🤔

My understanding is that you need the second case but this gems only support the first one.

[n-at-han-k]

Should this be closed? I would assume that this is a non-standard practice.
Stripe provides connect accounts for multitenant applications.