|
| 1 | +import { describe, expect, it } from 'vitest'; |
| 2 | +import { enforceQuerySecurity } from '../../utils/signozHelpers'; |
| 3 | + |
| 4 | +describe('enforceQuerySecurity', () => { |
| 5 | + const validQuery = "SELECT * FROM t WHERE attributes_string['tenant.id'] = {{.tenant_id}}"; |
| 6 | + |
| 7 | + it('injects tenant_id variable', () => { |
| 8 | + const payload = { |
| 9 | + compositeQuery: { chQueries: { A: { query: validQuery } } }, |
| 10 | + }; |
| 11 | + const result = enforceQuerySecurity(payload, 'tenant-1'); |
| 12 | + expect(result.error).toBeUndefined(); |
| 13 | + expect(result.payload.variables.tenant_id).toBe('tenant-1'); |
| 14 | + }); |
| 15 | + |
| 16 | + it('injects project_id variable when provided', () => { |
| 17 | + const payload = { |
| 18 | + compositeQuery: { chQueries: { A: { query: validQuery } } }, |
| 19 | + }; |
| 20 | + const result = enforceQuerySecurity(payload, 'tenant-1', 'project-1'); |
| 21 | + expect(result.payload.variables).toEqual({ |
| 22 | + tenant_id: 'tenant-1', |
| 23 | + project_id: 'project-1', |
| 24 | + }); |
| 25 | + }); |
| 26 | + |
| 27 | + it('does not inject project_id when not provided', () => { |
| 28 | + const payload = { |
| 29 | + compositeQuery: { chQueries: { A: { query: validQuery } } }, |
| 30 | + }; |
| 31 | + const result = enforceQuerySecurity(payload, 'tenant-1'); |
| 32 | + expect(result.payload.variables.project_id).toBeUndefined(); |
| 33 | + }); |
| 34 | + |
| 35 | + it('overwrites client-provided tenant_id (anti-spoofing)', () => { |
| 36 | + const payload = { |
| 37 | + variables: { tenant_id: 'attacker-tenant' }, |
| 38 | + compositeQuery: { chQueries: { A: { query: validQuery } } }, |
| 39 | + }; |
| 40 | + const result = enforceQuerySecurity(payload, 'legitimate-tenant'); |
| 41 | + expect(result.payload.variables.tenant_id).toBe('legitimate-tenant'); |
| 42 | + }); |
| 43 | + |
| 44 | + it('overwrites client-provided project_id (anti-spoofing)', () => { |
| 45 | + const payload = { |
| 46 | + variables: { project_id: 'attacker-project' }, |
| 47 | + compositeQuery: { chQueries: { A: { query: validQuery } } }, |
| 48 | + }; |
| 49 | + const result = enforceQuerySecurity(payload, 'tenant-1', 'real-project'); |
| 50 | + expect(result.payload.variables.project_id).toBe('real-project'); |
| 51 | + }); |
| 52 | + |
| 53 | + it('initializes variables object when missing', () => { |
| 54 | + const payload = { |
| 55 | + compositeQuery: { chQueries: { A: { query: validQuery } } }, |
| 56 | + }; |
| 57 | + const result = enforceQuerySecurity(payload, 'tenant-1', 'project-1'); |
| 58 | + expect(result.payload.variables).toEqual({ |
| 59 | + tenant_id: 'tenant-1', |
| 60 | + project_id: 'project-1', |
| 61 | + }); |
| 62 | + }); |
| 63 | + |
| 64 | + it('rejects query missing {{.tenant_id}} reference', () => { |
| 65 | + const payload = { |
| 66 | + compositeQuery: { |
| 67 | + chQueries: { |
| 68 | + malicious: { |
| 69 | + query: 'SELECT * FROM signoz_traces.distributed_signoz_index_v3 LIMIT 1000', |
| 70 | + }, |
| 71 | + }, |
| 72 | + }, |
| 73 | + }; |
| 74 | + const result = enforceQuerySecurity(payload, 'tenant-1'); |
| 75 | + expect(result.error).toBe('Query "malicious" is missing required {{.tenant_id}} tenant filter'); |
| 76 | + }); |
| 77 | + |
| 78 | + it('rejects when any one of multiple queries is missing tenant filter', () => { |
| 79 | + const payload = { |
| 80 | + compositeQuery: { |
| 81 | + chQueries: { |
| 82 | + good: { query: validQuery }, |
| 83 | + bad: { query: 'SELECT count() FROM t' }, |
| 84 | + }, |
| 85 | + }, |
| 86 | + }; |
| 87 | + const result = enforceQuerySecurity(payload, 'tenant-1'); |
| 88 | + expect(result.error).toContain('bad'); |
| 89 | + }); |
| 90 | + |
| 91 | + it('passes when all queries reference {{.tenant_id}}', () => { |
| 92 | + const payload = { |
| 93 | + compositeQuery: { |
| 94 | + chQueries: { |
| 95 | + q1: { query: validQuery }, |
| 96 | + q2: { |
| 97 | + query: `SELECT count() FROM t WHERE attributes_string['tenant.id'] = {{.tenant_id}}`, |
| 98 | + }, |
| 99 | + }, |
| 100 | + }, |
| 101 | + }; |
| 102 | + const result = enforceQuerySecurity(payload, 'tenant-1'); |
| 103 | + expect(result.error).toBeUndefined(); |
| 104 | + }); |
| 105 | + |
| 106 | + it('passes when no chQueries present (non-clickhouse payload)', () => { |
| 107 | + const payload = { compositeQuery: {} }; |
| 108 | + const result = enforceQuerySecurity(payload, 'tenant-1'); |
| 109 | + expect(result.error).toBeUndefined(); |
| 110 | + expect(result.payload.variables.tenant_id).toBe('tenant-1'); |
| 111 | + }); |
| 112 | + |
| 113 | + it('does not mutate the original payload', () => { |
| 114 | + const original = { |
| 115 | + variables: { tenant_id: 'original' }, |
| 116 | + compositeQuery: { chQueries: { A: { query: validQuery } } }, |
| 117 | + }; |
| 118 | + enforceQuerySecurity(original, 'new-tenant'); |
| 119 | + expect(original.variables.tenant_id).toBe('original'); |
| 120 | + }); |
| 121 | +}); |
0 commit comments