Skip to content

DEVELOPING.md

Latest commit

 

History

History
299 lines (188 loc) · 8.14 KB

DEVELOPING.md

File metadata and controls

299 lines (188 loc) · 8.14 KB

Developing for GuideLLM

Thank you for your interest in contributing to GuideLLM! This document provides detailed instructions for setting up your development environment, implementing changes, and adhering to the project's best practices. Your contributions help us grow and improve this project.

Setting Up Your Development Environment

Prerequisites

Before you begin, ensure you have the following installed:

  • Python 3.10 or higher
  • pip (Python package manager)
  • Tox
  • Git

Cloning the Repository

  1. Clone the repository to your local machine:

    git clone https://github.com/vllm-project/guidellm.git
cd guidellm

  2. (Optional) If you plan to contribute changes back, fork the repository and clone your fork instead:

    git clone https://github.com/<your-username>/guidellm.git
cd guidellm

Installing Dependencies

To install the required dependencies for the package and development, run:

pip install -e ./[dev]

The -e flag installs the package in editable mode, allowing you to make changes to the code without reinstalling it. The [dev] part installs additional dependencies needed for development, such as testing and linting tools.

Implementing Changes

Writing Code

  1. Create a Branch: Create a new branch for your changes:

    git checkout -b feature/your-feature-name

  2. Make Changes: Implement your changes in the appropriate files. Ensure that all public functions and classes have clear and concise docstrings.

  3. Update Documentation: Update or add documentation to reflect your changes. This includes updating README files, docstrings, and any relevant guides.

Running Quality, Style, and Type Checks

We use Tox to simplify running various tasks in isolated environments. Tox standardizes environments to ensure consistency across local development, CI/CD pipelines, and releases. This guarantees that the code behaves the same regardless of where it is executed.

Additionally, to ensure consistency and quality of the codebase, we use ruff for linting and styling, isort for sorting imports, mypy for type checking, and mdformat for formatting Markdown files.

Code Quality and Style

To check code quality, including linting and formatting:

tox -e quality

To automatically fix style issues:

tox -e style

Type Checking

To ensure type safety using Mypy:

tox -e types

Link Checking

To ensure valid links added to the documentation / Markdown files:

tox -e links

Automating Quality Checks with Pre-Commit Hooks (Optional)

We use pre-commit to automate quality checks before commits. Pre-commit hooks run checks like linting, formatting, and type checking, ensuring that only high-quality code is committed.

To install the pre-commit hooks, run:

pre-commit install

This will set up the hooks to run automatically before each commit. To manually run the hooks on all files, use:

pre-commit run --all-files

Running Tests

For testing, we use pytest as our testing framework. We have different test suites for unit tests, integration tests, and end-to-end tests. To run the tests, you can use Tox, which will automatically create isolated environments for each test suite. Tox will also ensure that the tests are run in a consistent environment, regardless of where they are executed.

Running All Tests

To run all tests:

tox

Running Specific Tests

  • Unit tests (focused on individual components with mocking):

    tox -e test-unit

  • Integration tests (focused on interactions between components ideally without mocking):

    tox -e test-integration

  • End-to-end tests (focused on the entire system and user interfaces):

    tox -e test-e2e

Running Tests with Coverage

To ensure your changes are covered by tests, run:

tox -e test-unit -- --cov=guidellm --cov-report=html

Review the coverage report to confirm that your new code is adequately tested.

Opening a Pull Request

  1. Push Changes: Push your branch to your forked repository (if you forked):

    git push origin feature/your-feature-name

  2. Open a Pull Request: Go to the original repository and open a pull request. Use the following template for your pull request description:

    # Title; ex: Add feature X to improve Y

## Summary:

Short paragraph detailing the pull request changes and reasoning in addition to any relevant context.

## Details:

- Detailed list of changes made in the pull request

## Test Plan:

- Detailed list of steps to test the changes made in the pull request

## Related Issues

- List of related issues or other pull requests; ex: "Fixes #1234"

  3. Address Feedback: Respond to any feedback from reviewers and make necessary changes.

Developing the Web UI

The GuideLLM project includes a frontend UI located in src/ui, built using Next.js. This section provides instructions for working on the UI.

Getting Started

First, install dependencies:

npm install

Then, start the local development server:

npm run dev

Then open http://localhost:3000 in your browser.

Building for Production

To build the app for production (output in the out directory):

npm run build

Running UI Tests

  • Unit tests:

    npm run test:unit

  • Integration tests:

    npm run test:integration

  • Integration+Unit tests with coverage:

    npm run coverage

  • End-to-end tests (using Cypress, ensure live dev server):

    npm run test:e2e

Code Quality and Styling

  • Fix styling issues:

    npm run format

  • Run ESLint checks:

    npm run lint

  • Run TS type checks:

    npm run type-checks
Tagging Tests

Reference https://www.npmjs.com/package/jest-runner-groups Add @group with the tag in a docblock at the top of the test file to indicate which types of tests are contained within. Can't distinguish between different types of tests in the same file.

/**
 * Admin dashboard tests
 *
 * @group smoke
 * @group sanity
 * @group regression
 */

🧪 UI Development Notes

During development, it can be helpful to view sample data. We include a sample benchmark run wired into the Redux store under:

src/ui/lib/store/[runInfo/workloadDetails/benchmarks]WindowData.ts

In the future this will be replaced by a configurable untracked file for dev use.

Logging

Logging is useful for learning how GuideLLM works and finding problems.

Logging is set using the following environment variables:

  • GUIDELLM__LOGGING__DISABLED: Disable logging (default: false).
  • GUIDELLM__LOGGING__CLEAR_LOGGERS: Clear existing loggers from loguru (default: true).
  • GUIDELLM__LOGGING__CONSOLE_LOG_LEVEL: Log level for console logging (default: none, options: DEBUG, INFO, WARNING, ERROR, CRITICAL).
  • GUIDELLM__LOGGING__LOG_FILE: Path to the log file for file logging (default: guidellm.log if log file level set else none)
  • GUIDELLM__LOGGING__LOG_FILE_LEVEL: Log level for file logging (default: INFO if log file set else none).

If logging isn't responding to the environment variables, run the guidellm config command to validate that the environment variables match and are being set correctly.

Additional Resources